Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ros2] ENABLE_DISPLAY_TESTS, and make camera tests more robust #854

Merged
merged 1 commit into from Dec 12, 2018

Conversation

Projects
None yet
3 participants
@chapulina
Copy link
Contributor

commented Dec 12, 2018

This way, to build camera test one needs to run:

colcon build --packages-select gazebo_plugins --cmake-args -DENABLE_DISPLAY_TESTS=true

Camera tests will be build in the OSRF build farm, but not on the ROS build farm.

@j-rivero

This comment has been minimized.

Copy link
Contributor

commented Dec 12, 2018

I'm stiff fighting with the failing test, unrelated to this PR.

@j-rivero j-rivero self-requested a review Dec 12, 2018

@chapulina

This comment has been minimized.

Copy link
Contributor Author

commented Dec 12, 2018

Last night test_node was also failing locally for me when I built rclcpp from source. The executor's thread is never joining in case there's more than one non-static node. I debugged for a long time and I'm still not sure how to fix it, whether this has been recently introduced, and why it passes on the ROS farm...

@chapulina chapulina merged commit 297d30c into ros2 Dec 12, 2018

1 of 3 checks passed

Bpr__gazebo_ros_pkgs__ubuntu_bionic_amd64 Build finished.
Details
ros2_gazebo_pkgs-ci-pr_any_crystal-bionic-amd64 Build finished.
Details
Cpr__gazebo_ros_pkgs__ubuntu_bionic_amd64 Build finished.
Details

@chapulina chapulina deleted the ENABLE_DISPLAY_TESTS branch Dec 12, 2018

@chapulina chapulina added the ros2 label Dec 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.