Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ros2] Port hand of god to ROS2 #957

Merged
merged 2 commits into from Aug 2, 2019

Conversation

@shiveshkhaitan
Copy link

commented Jul 17, 2019

Port gazebo_ros_hand_of_god plugin to ROS2.

Example usage:

<plugin name="hand_of_god" filename="libgazebo_ros_hand_of_god.so">
  <ros>
    <namespace>/demo</namespace>
  </ros>
  <link_name>link</link_name>
  <frame_id>link</frame_id>
</plugin>

Migration guide at ROS 2 Migration: Hand of God

@chapulina chapulina self-requested a review Jul 17, 2019

@chapulina chapulina added the ros2 label Jul 17, 2019

@chapulina

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2019

@osrf-jenkins run tests please

@chapulina
Copy link
Contributor

left a comment

LGTM! I just have a couple of small comments, and it needs rebasing

@chapulina chapulina force-pushed the shiveshkhaitan:hand_of_god branch from 55209b3 to 337dd25 Aug 2, 2019

@chapulina chapulina merged commit d84c473 into ros-simulation:dashing Aug 2, 2019

0 of 2 checks passed

Dpr__gazebo_ros_pkgs__ubuntu_bionic_amd64 Build finished.
Details
ros2_gazebo_pkgs-ci-pr_any_dashing-bionic-amd64 Build finished.
Details
shiveshkhaitan added a commit to shiveshkhaitan/gazebo_ros_pkgs that referenced this pull request Aug 15, 2019
[ros2] Port hand of god to ROS2 (ros-simulation#957)
* [ros2] Port hand of god to ROS2

* Minor fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.