Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ros2] Backport depth camera to dashing #967

Merged
merged 4 commits into from Aug 21, 2019

Conversation

@shiveshkhaitan
Copy link

commented Jul 26, 2019

Back port depth camera and openni kinnect to dashing #932

@chapulina chapulina added the ros2 label Jul 30, 2019

@chapulina chapulina self-requested a review Jul 30, 2019

shiveshkhaitan and others added 2 commits Aug 11, 2019
don't install header that will be removed
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Copy link
Contributor

left a comment

LGTM! The usage remains exactly the same as on eloquent, great job!

I just moved the depth camera header from include to src so it isn't installed: 8719c30. This way, we don't need to go through a deprecation cycle for it (unless someone comes asking us to install it in the future).

Will merge once we get clean CI.

fix linting error
Signed-off-by: Louise Poubel <louise@openrobotics.org>

@chapulina chapulina merged commit 6b4e342 into ros-simulation:dashing Aug 21, 2019

1 of 2 checks passed

Dpr__gazebo_ros_pkgs__ubuntu_bionic_amd64 Build finished.
Details
ros2_gazebo_pkgs-ci-pr_any_dashing-bionic-amd64 Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.