Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address reviews on #868 #972

Merged
merged 14 commits into from Aug 21, 2019

Conversation

@shiveshkhaitan
Copy link

commented Aug 6, 2019

This addresses the requested changes on #868.

chapulina and others added 9 commits Feb 14, 2019

@chapulina chapulina added the ros2 label Aug 6, 2019

@chapulina chapulina self-requested a review Aug 6, 2019

shiveshkhaitan and others added 3 commits Aug 8, 2019
more tests, joint types
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Copy link
Contributor

left a comment

I pushed some changes on 5293a5a, let me know if anything doesn't look good to you.

gazebo_msgs/srv/GetModelProperties.srv Show resolved Hide resolved
gazebo_ros/src/gazebo_ros_properties.cpp Outdated Show resolved Hide resolved
gazebo_ros/src/gazebo_ros_properties.cpp Outdated Show resolved Hide resolved
shiveshkhaitan and others added 2 commits Aug 20, 2019
Revert changes to GetModelProperties message
Document gazebo_ros_properties header
Convert msgs pose to math pose and use it on SetCoG
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Copy link
Contributor

left a comment

Thank you @nzlz for starting the migration and @shiveshkhaitan for wrapping it up. LGTM, just waiting on CI.

@chapulina chapulina merged commit ad6c482 into ros-simulation:dashing Aug 21, 2019

0 of 2 checks passed

Dpr__gazebo_ros_pkgs__ubuntu_bionic_amd64 Build finished.
Details
ros2_gazebo_pkgs-ci-pr_any_dashing-bionic-amd64 Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.