Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] Backport multicamera to dashing #984

Merged
merged 2 commits into from Aug 23, 2019

Conversation

@shiveshkhaitan
Copy link

commented Aug 21, 2019

Backport gazebo_ros_multi_camera, gazebo_ros_triggered_multicamera and multi_camera_plugin #939 to dashing

@chapulina chapulina self-requested a review Aug 22, 2019

@chapulina chapulina added the ros2 label Aug 22, 2019

fix test - use correct world
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Copy link
Contributor

left a comment

Nice work! I fixed a typo on 488c747 to fix the test. We probably need to port this to ros2.

Will merge when CI comes back happy.

@chapulina

This comment has been minimized.

Copy link
Contributor

commented Aug 23, 2019

@ros-pull-request-builder retest this please

@chapulina chapulina merged commit f9724bd into ros-simulation:dashing Aug 23, 2019

1 of 2 checks passed

Dpr__gazebo_ros_pkgs__ubuntu_bionic_amd64 Build finished.
Details
ros2_gazebo_pkgs-ci-pr_any_dashing-bionic-amd64 Build finished.
Details
@shiveshkhaitan

This comment has been minimized.

Copy link
Author

commented Aug 24, 2019

I fixed a typo on 488c747 to fix the test.

Sorry about this. I think on rebuilding, previously installed worlds do not get removed. So when I tried building, using previously installed gazebo_ros_multicamera.world, the tests passed

We probably need to port this to ros2

In ros2, the world name is gazebo_ros_multicamera.world and its consistent with the one loaded in test. Should I change both of them to gazebo_ros_multi_camera.world?

@chapulina

This comment has been minimized.

Copy link
Contributor

commented Aug 24, 2019

Should I change both of them to gazebo_ros_multi_camera.world?

Should be ok the way it is now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.