Fixing auto lint tests and making one flake8 change

ros-visualization · Nov 20, 2018 · ce483bd · ce483bd
1 parent a6cba30
commit ce483bd
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 53 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -16,12 +16,15 @@ install(FILES
 if(BUILD_TESTING)
   find_package(ament_cmake_pytest REQUIRED)
   find_package(ament_lint_auto REQUIRED)
+
+  # Disabling copyright test. The copyright used in this package does not conform to
+  # ament's copyright tests
+  set(ament_cmake_copyright_FOUND TRUE)
   ament_lint_auto_find_test_dependencies()
 
   ament_add_pytest_test(python_qt_binding test
     APPEND_ENV PYTHONPATH=${CMAKE_CURRENT_BINARY_DIR}
-    TIMEOUT 90
-)
+    TIMEOUT 90)
 endif()
 
 ament_package()
diff --git a/package.xml b/package.xml
@@ -30,12 +30,11 @@
 
   <exec_depend>python3-qt5-bindings</exec_depend>
 
-  <test_depend>ament_cmake_pytest</test_depend>
   <test_depend>ament_lint_auto</test_depend>
-  <test_depend>ament_flake8</test_depend>
-  <test_depend>ament_pep257</test_depend>
-  <test_depend>python3-pytest</test_depend>
+  <test_depend>ament_lint_common</test_depend>
+  <test_depend>ament_cmake_pytest</test_depend>
 
+
   <export>
     <build_type>ament_cmake</build_type>
   </export>

diff --git a/src/python_qt_binding/binding_helper.py b/src/python_qt_binding/binding_helper.py
@@ -116,7 +116,7 @@ def _select_qt_binding(binding_name=None, binding_order=None):
 
     if not QT_BINDING:
         raise ImportError(
-            "Could not find Qt binding (looked for: %s):\n%s" %
+            'Could not find Qt binding (looked for: %s):\n%s' %
             (', '.join(["'%s'" % b for b in binding_order]), '\n'.join(error_msgs)))
 
 

diff --git a/test/__init__.py b/test/__init__.py
diff --git a/test/test_flake8.py b/test/test_flake8.py
diff --git a/test/test_pep257.py b/test/test_pep257.py