Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove :: from shiboken include path #48

Merged

Conversation

@jspricke
Copy link
Contributor

jspricke commented Sep 7, 2018

The Variable QT_INCLUDE_DIR_WITH_COLONS is iteratively generated
starting with an empty string and adding :${dir}. This always results in
a colon as the first symbol. When combining it with the INCLUDE_PATH
adding a second colon results in :: in the string. The shiboken command
line utility currently has a bug generating an invalid command out of
this (-I without a string). This seems to have been fixed in the
development version already. Still this double colon ins superfluous so
let's remove it.

The Variable QT_INCLUDE_DIR_WITH_COLONS is iteratively generated
starting with an empty string and adding :${dir}. This always results in
a colon as the first symbol. When combining it with the INCLUDE_PATH
adding a second colon results in :: in the string. The shiboken command
line utility currently has a bug generating an invalid command out of
this (-I without a string). This seems to have been fixed in the
development version already. Still this double colon ins superfluous so
let's remove it.
@dirk-thomas

This comment has been minimized.

Copy link
Member

dirk-thomas commented Sep 7, 2018

Thanks for the fix.

@dirk-thomas dirk-thomas merged commit 3d3efad into ros-visualization:kinetic-devel Sep 7, 2018
@jspricke jspricke deleted the jspricke:kinetic-devel branch Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.