Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added check to ensure we do not fail if PyQt5 is not in sys.modules #290

Merged
merged 1 commit into from Nov 12, 2014

Conversation

Projects
None yet
2 participants
@ablasdel
Copy link
Contributor

commented Nov 11, 2014

No description provided.

if sys.modules['PyQt5']:
sys.modules['PyQt5'] = None
try:
if sys.modules['PyQt5']:

This comment has been minimized.

Copy link
@dirk-thomas

dirk-thomas Nov 11, 2014

Member

Can you do this here instead and avoid the try/catch?

if 'PyQt5' in sys.modules:

This comment has been minimized.

Copy link
@ablasdel

ablasdel Nov 11, 2014

Author Contributor

I did that first but he said it started segfaulting when he ran it again. I didn't understand why it would so I thought I would try this.

This comment has been minimized.

Copy link
@ablasdel

ablasdel Nov 11, 2014

Author Contributor

You should be right. Maybe I spelled it wrong? I'll try this way again without the "and sys.modules['PyQt5']:"

ablasdel added a commit that referenced this pull request Nov 12, 2014

Merge pull request #290 from ablasdel/groovy-devel
added check to ensure we do not fail if PyQt5 is not in sys.modules

@ablasdel ablasdel merged commit df1dfd3 into ros-visualization:groovy-devel Nov 12, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.