Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

widget selection is using the wrong type #123

Closed
christianrauch opened this issue Dec 11, 2022 · 1 comment
Closed

widget selection is using the wrong type #123

christianrauch opened this issue Dec 11, 2022 · 1 comment

Comments

@christianrauch
Copy link

The selection of the matching widget per parameter type in

def add_editor_widgets(self, parameters, descriptors):
for parameter, descriptor in zip(parameters, descriptors):
if parameter.type_ not in EDITOR_TYPES:
continue
logging.debug('Adding editor widget for {}'.format(parameter.name))
editor_widget = EDITOR_TYPES[parameter.type_](
self._param_client, parameter, descriptor
)
self._editor_widgets[parameter.name] = editor_widget
editor_widget.display(self.grid)

is using the type of the default parameter instead of the type from the parameter description. This means that typed parameters without a default value do not get a configuration widget.

As en example, the new array configuration from #108 will not work with parameters where ros2 param describe returns

  Type: double array
@christianrauch
Copy link
Author

Fixed via #124.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant