Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additionally support Qt5 #101

Merged
merged 2 commits into from Apr 27, 2016

Conversation

Projects
None yet
1 participant
@dirk-thomas
Copy link
Member

dirk-thomas commented Apr 25, 2016

With these patches the same code base can run with:

  • ROS Indigo / Jade using Qt 4
  • ROS Kinetic (and higher) using Qt 5

The version dependency on python_qt_binding ensures that the packages which use QtWidgets are getting the changes from ros-visualization/python_qt_binding#31.

This is required for a release into Kinetic.

@dirk-thomas dirk-thomas merged commit c9cf9e7 into master Apr 27, 2016

@dirk-thomas dirk-thomas deleted the qt5 branch Apr 27, 2016

@dirk-thomas

This comment has been minimized.

Copy link
Member Author

dirk-thomas commented Apr 27, 2016

This repo needs a similar abstraction package for python-qt-binding-glas the common plugins (ros-visualization/rqt_common_plugins#359 (comment)): https://github.com/ros-visualization/gl_dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.