Revert "Complete the full set of *Ptr typedefs (#106)" #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 506541a.
|
@ros-pull-request-builder retest this please |
seanyen
added a commit
to seanyen/realtime_tools
that referenced
this pull request
Dec 3, 2018
Add back typedef for ResultPtr & FeedbackPtr because of actionlib recent changes: ros/actionlib#113
@mikaelarguedas: Which ROS distribution do you want to target this for? |
|
@ipa-mdl Sorry for the late reply, at the time of the revert I was thinking of the next ROS version (so ROS-Noetic). I'll leave it up to the current maintainer (@mjcarroll) to give feedback. It may be worth opening an issue linking to #106 for context and tracking progress |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 506541a.
As packages already released in verious ROS distribution define conflicting types for these definitions.
We will need to wait for the next ROS distribution to roll this out and fix downstream packages accordingly.
@bmagyar FYI