Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed default value for rosparam. closes #69 #70

Merged
merged 2 commits into from
Mar 8, 2017
Merged

fixed default value for rosparam. closes #69 #70

merged 2 commits into from
Mar 8, 2017

Conversation

piyushk
Copy link
Contributor

@piyushk piyushk commented Mar 7, 2017 •
edited
Loading

Closes #69

mikaelarguedas
mikaelarguedas approved these changes Mar 8, 2017
View reviewed changes
Copy link
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the patch looks good to me. Will try to figure out why all tests failed before merging

@mikaelarguedas
Copy link
Member

@ros-pull-request-builder retest this please

@mikaelarguedas
Copy link
Member

failing test on Lunar is not related to this PR and ticketed on #45

thanks @piyushk for the contribution!

@mikaelarguedas mikaelarguedas merged commit a8b0c18 into ros:indigo-devel Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikaelarguedas mikaelarguedas mikaelarguedas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piyushk @mikaelarguedas