Minor windows fixes #359
Closed
Minor windows fixes #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
added a commit
that referenced
this pull request
Feb 12, 2013
dirk-thomas
added a commit
that referenced
this pull request
Feb 12, 2013
|
I just applied the first and third patch to go on with local testing. |
|
The second patch should be part of the next pull request which requires the variable introduced in the changes. |
|
Thanks dirk and yes, I should have unwound the second one before pull requesting. I'll be more strict on it in future. Thanks. |
cwecht
pushed a commit
to cwecht/catkin
that referenced
this pull request
Mar 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some trivial fixes...bigger fixes are pending and probably need some discussion.
21cfef6: it converts windows paths (e.g. ros\core\mk) into *nix paths so that cmake doesn't fall over when it sees backslashes. Further discussion is at #355
c691275: haven't used it here, but will in a coming patch. Useful to have there at any rate.
10fb4ea: comments in the commit.