Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a blacklist option to make_isolated #1027

Merged

Conversation

@artivis
Copy link
Contributor

commented Aug 14, 2019

Add a blacklist option to catkin_make_isolated, e.g.

catkin_make_isolated --ignore-pkg foo bar

Fix #1026

Signed-off-by: artivis <jeremie.deray@canonical.com>
Copy link
Member

left a comment

Thanks for working on this patch.

Just as a note: catkin_make_isolated is not being developed anymore. So you might want to look into using alternatives (colcon, catkin_tools) which already offer this (and many more) features.

python/catkin/builder.py Outdated Show resolved Hide resolved
bin/catkin_make_isolated Outdated Show resolved Hide resolved
bin/catkin_make_isolated Outdated Show resolved Hide resolved
python/catkin/builder.py Outdated Show resolved Hide resolved
artivis added 2 commits Aug 14, 2019
fix
@artivis

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

@dirk-thomas Thanks for the review, PR updated accordingly.

python/catkin/builder.py Outdated Show resolved Hide resolved
@dirk-thomas dirk-thomas merged commit 0a8f356 into ros:kinetic-devel Aug 14, 2019
3 checks passed
3 checks passed
Kpr__catkin__ubuntu_xenial_amd64 Build finished.
Details
Mpr__catkin__ubuntu_bionic_amd64 Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@artivis artivis deleted the artivis:feature/make_isolated_blacklist branch Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.