Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve unicode handling #615

Merged
merged 1 commit into from Apr 11, 2014

Conversation

Projects
None yet
4 participants
@dirk-thomas
Copy link
Member

commented Apr 4, 2014

As a follow up to #578 and #595 I have another patch to improve unicode handling.

Added another unit test which check processing when output is encoded.

@josegaert @nicolasWDC @saljam @wjwwood @yukota Since you have all been part of the previous discussion I would like to ask you to try the changes of this branch with your specific scenario.

Since these unicode issues are highly specific to your environment, available locale and output of your tools the more people will validate that it works the more confident we can be that it does not break things (as it has happened before). Please comment on this ticket with either feedback ("it works for you" as well as "it doesn't (please with as much details as possible)").

@saljam

This comment has been minimized.

Copy link

commented Apr 5, 2014

LGTM.

@yukota

This comment has been minimized.

Copy link

commented Apr 6, 2014

LGTM!!

@wjwwood

This comment has been minimized.

Copy link
Member

commented Apr 8, 2014

+1

dirk-thomas added a commit that referenced this pull request Apr 11, 2014

Merge pull request #615 from ros/unicode_again
improve unicode handling

@dirk-thomas dirk-thomas merged commit 17b6dd4 into indigo-devel Apr 11, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@dirk-thomas dirk-thomas deleted the unicode_again branch Apr 11, 2014

cwecht pushed a commit to cwecht/catkin that referenced this pull request Mar 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.