Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bad usage of IMPORTED_IMPLIB by IMPORTED_LOCATION #616

Merged
merged 1 commit into from Apr 11, 2014

Conversation

Projects
None yet
3 participants
@vrabaud
Copy link
Member

commented Apr 6, 2014

ok, that was NOT FUN. To test this, just use the tf2_geometry_msgs. It DEPENDS on orocos_kdl in catkin_package() but this library does not appear in the *.cmake files. My patch fixes that.

Info at: http://www.cmake.org/Wiki/CMake/Tutorials/Exporting_and_Importing_Targets and http://www.cmake.org/cmake/help/v2.8.12/cmake.html#prop_tgt:IMPORTED_LOCATION

@vrabaud

This comment has been minimized.

Copy link
Member Author

commented Apr 7, 2014

I don't understand why Travis is failing.
On the other hand, what I am solving is needed to prevent some failures on the farm:
http://jenkins.ros.org/job/ros-indigo-image-rotate_binarydeb_trusty_i386/2/

@tfoote

This comment has been minimized.

Copy link
Member

commented Apr 7, 2014

The failure is a unicode issue in 2.7 it passes in 3.3

On Mon, Apr 7, 2014 at 12:59 AM, Vincent Rabaud notifications@github.comwrote:

I don't understand why Travis is failing.
On the other hand, what I am solving is needed to prevent some failures on
the farm:
http://jenkins.ros.org/job/ros-indigo-image-rotate_binarydeb_trusty_i386/2/

Reply to this email directly or view it on GitHubhttps://github.com//pull/616#issuecomment-39704448
.

@dirk-thomas

This comment has been minimized.

Copy link
Member

commented Apr 7, 2014

The failure on Python 2.7 is addressed in #615. That was the whole reason to add the travis file recently.

@dirk-thomas

This comment has been minimized.

Copy link
Member

commented Apr 7, 2014

@vrabaud I have ran a build of orocos_kdl and (a stripped down version of tf2_geometry_msgs. What ever version of catkin I use (the unpatched as well as the patched version) the orocos-kdl library is never part of the downstream package CMake config file. How did you actually tested your patch? Can you please post some detailed command sequences and expected / actual output?

@vrabaud

This comment has been minimized.

Copy link
Member Author

commented Apr 8, 2014

@dirk-thomas , I just create a workspace with:

git clone https://github.com/ros/geometry_experimental.git
git clone https://github.com/vrabaud/catkin.git
git clone https://github.com/ros-perception/image_pipeline.git

(checkout all the indigo for each)
source /opt/ros/indigo/setup.sh and call:

./src/catkin/bin/catkin_make

and it works for me.

@dirk-thomas dirk-thomas added the bug label Apr 8, 2014

@dirk-thomas

This comment has been minimized.

Copy link
Member

commented Apr 8, 2014

I was able reproduce the problem and also verify that the same patch is required for Hydro and Groovy. Thank you for the PR.

dirk-thomas added a commit that referenced this pull request Apr 11, 2014

Merge pull request #616 from vrabaud/indigo-devel
fix bad usage of IMPORTED_IMPLIB by IMPORTED_LOCATION

@dirk-thomas dirk-thomas merged commit 5b2ecc4 into ros:indigo-devel Apr 11, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build failed
Details

cwecht pushed a commit to cwecht/catkin that referenced this pull request Mar 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.