Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor code from run_tests.py into Python module #678

Merged
merged 1 commit into from Aug 22, 2014

Conversation

dirk-thomas
Copy link
Member

No description provided.

try:
tree = ElementTree(None, filename)
except ParseError:
# print('Invalid XML in result file "%s"' % filename)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. But sometimes I use those commented print statements to trace issues so I will keep it for now.

@wjwwood
Copy link
Member

wjwwood commented Aug 21, 2014

+1

@dirk-thomas dirk-thomas changed the title rafactoring code from run_tests.py into Python module refactor code from run_tests.py into Python module Aug 21, 2014
@tfoote
Copy link
Member

tfoote commented Aug 21, 2014

+1

dirk-thomas added a commit that referenced this pull request Aug 22, 2014
refactor code from run_tests.py into Python module
@dirk-thomas dirk-thomas merged commit 43d7b44 into indigo-devel Aug 22, 2014
@dirk-thomas dirk-thomas deleted the refactor_run_tests branch August 22, 2014 17:10
k-okada pushed a commit to k-okada/catkin that referenced this pull request Sep 8, 2014
refactor code from run_tests.py into Python module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants