Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

free impl_ in AbstractMetaObjectBase destructor #103

Merged
merged 1 commit into from
Sep 14, 2018

Conversation

yechun1
Copy link

@yechun1 yechun1 commented Aug 15, 2018

The constructor allocates field impl_ of class_loader::impl::AbstractMetaObjectBase but the destructor and whatever functions it calls do not free it.

Signed-off-by: Chris Ye chris.ye@intel.com

@yechun1
Copy link
Author

yechun1 commented Sep 7, 2018

Just checked the CI fails all related with build system itself.

The command "python3 -u ./src/ament/ament_tools/scripts/ament.py build --build-tests --ament-cmake-args -DPYTHON_VERSION=3 -- --end-with class_loader" exited with 1.
8430.19s$ python3 -u ./src/ament/ament_tools/scripts/ament.py test --skip-build --skip-install --only class_loader
844Traceback (most recent call last):
845 File "./src/ament/ament_tools/scripts/ament.py", line 139, in
846 from ament_tools.package_types.ament import entry_point_data as ament_entry_point_data # noqa
847 File "/home/travis/build/ros/class_loader/build/src/ament/ament_tools/ament_tools/package_types/ament.py", line 15, in
848 from catkin_pkg.package import package_exists_at
849ImportError: No module named 'catkin_pkg'

The constructor allocates field impl_ of class_loader::impl::AbstractMetaObjectBase but the destructor and whatever functions it calls do not free it.

Signed-off-by: Chris Ye <chris.ye@intel.com>
@mikaelarguedas
Copy link
Member

CI on ROS2 packages using it to make sure it doesn't have side effects.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Copy link
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @yechun1 for the contribution

@mikaelarguedas mikaelarguedas merged commit 189aa8a into ros:ros2 Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants