Declare version numbers and install cmake version config file #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently version 0.2.8 Use version number variable in pkc-config template
isucan
added a commit
that referenced
this pull request
Oct 13, 2015
Declare version numbers and install cmake version config file
| if(WIN32 AND NOT CYGWIN) | ||
| set(CMAKE_CONFIG_INSTALL_DIR CMake) | ||
| else() | ||
| set(CMAKE_CONFIG_INSTALL_DIR ${CMAKE_INSTALL_DATAROOTDIR}/${PROJECT_NAME}/cmake/) |
There was a problem hiding this comment.
Out of curiosity: where does CMAKE_INSTALL_DATAROOTDIR point to? And where does it get set?
There was a problem hiding this comment.
whoops, that is set by GNUInstallDirs
There was a problem hiding this comment.
which was added in ros/urdfdom#41 but not here it is already present in urdfdom
There was a problem hiding this comment.
I was just trying to be consistent with that other pull request, though I know there has been some controversy about GNUInstallDirs
There was a problem hiding this comment.
To be added in #23
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cmake version config file is similar to the version added in ros/urdfdom_headers#17 and the logic for hte Windows install location is based on ros/urdfdom#41 by @traversaro
Some of the open issues call for version number bumping, so this should help with that.