Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a simple Heartbeat-DiagnosticTask #73

Merged
merged 5 commits into from Feb 9, 2018
Merged

Conversation

@LoyVanBeek
Copy link
Contributor

LoyVanBeek commented Feb 3, 2018

Basic use-case for me is to simply know whether a node is alive or not. The reason to build this is we have a NVidia Jetson board running a ROS service. Sometimes the board isn't booting for whatever reason. Simply broadcasting "I'm alive!" already helps in detecting that.

It's a service, so various existing DiagnosticTasks do not make sense.

Example use is in tue-robotics/image_recognition#55

loy and others added 4 commits Feb 3, 2018
This currently fails (https://travis-ci.org/ros/diagnostics/builds/336956455#L2162) with ```ImportError: "from catkin_pkg.package import parse_package" failed: No module named catkin_pkg.package```
This reverts commit dcc08e4.
@LoyVanBeek

This comment has been minimized.

Copy link
Contributor Author

LoyVanBeek commented Feb 3, 2018

For some reason, the Travis build is broken with

ImportError: "from catkin_pkg.package import parse_package" failed: No module named catkin_pkg.package

on https://travis-ci.org/ros/diagnostics/builds/336956455#L2162

@reinzor
reinzor approved these changes Feb 4, 2018
@trainman419

This comment has been minimized.

Copy link
Contributor

trainman419 commented Feb 8, 2018

This looks great! I fixed the travis CI build in #76; if you rebase or merge you should get a passing build.

@LoyVanBeek

This comment has been minimized.

Copy link
Contributor Author

LoyVanBeek commented Feb 9, 2018

🎉

@trainman419 trainman419 merged commit 11d28fb into ros:indigo-devel Feb 9, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.