Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove generate_rand_vectors() from a number of tests. #227

Merged
merged 2 commits into from May 14, 2017

Conversation

@clalancette
Copy link
Contributor

commented Apr 25, 2017

It was never used, so there is no reason to carry it around.
While I was in these tests, kill a bunch of trailing
whitespace.

Signed-off-by: Chris Lalancette clalancette@osrfoundation.org

@tfoote
Copy link
Member

left a comment

Thanks these are definitely removable. However your commit is majority whitespace changes which are unrelated and may cause issues with the current outstanding PRs. We can consider cleaning it up, but we should at least isolate it into a separate commit to allow easier merging.

@clalancette

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2017

Yeah, that's fine. I'll split this into 2 different commits, one for the whitespace, one for the change.

clalancette added 2 commits Apr 25, 2017
Remove a slew of trailing whitespace.
Signed-off-by: Chris Lalancette <clalancette@osrfoundation.org>
Remove generate_rand_vectors() from a number of tests.
It was never used, so there is no reason to carry it around.

Signed-off-by: Chris Lalancette <clalancette@osrfoundation.org>

@clalancette clalancette force-pushed the clalancette:remove-unused-functions branch from 9b7433a to 3234d91 Apr 25, 2017

@tfoote tfoote merged commit d5da804 into ros:indigo-devel May 14, 2017

2 of 4 checks passed

Kpr__geometry2__ubuntu_xenial_amd64 Build finished.
Details
Lpr__geometry2__ubuntu_xenial_amd64 Build finished.
Details
Ipr__geometry2__ubuntu_trusty_amd64 Build finished.
Details
Jpr__geometry2__ubuntu_trusty_amd64 Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.