Skip to content
This repository was archived by the owner on May 31, 2025. It is now read-only.

Removed print statements from buffer interface #530

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Removed print statements from buffer interface #530

merged 1 commit into from
Apr 5, 2022
+0 −3

Conversation

@jlunenburg
Copy link
Contributor

No description provided.

@jlunenburg jlunenburg requested a review from tfoote as a code owner March 22, 2022 20:43
@MatthijsBurgh
Copy link
Contributor

@tfoote friendly ping ;)

tfoote
tfoote approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@tfoote tfoote left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks yeah, these are unnecessary and can be cleaned up.

The documentation reads that it was potentially used for testing more than expected to be used as the primary method. But I think it does appear to be the primary usage.

@tfoote tfoote merged commit f3e6990 into ros:noetic-devel Apr 5, 2022
MatthijsBurgh added a commit to MatthijsBurgh/geometry2 that referenced this pull request Sep 4, 2023
@MatthijsBurgh
Remove 'efficient copy' prints
c4c9b83 
Matching ros/geometry2#530
@MatthijsBurgh MatthijsBurgh mentioned this pull request Sep 4, 2023
Merged
ahcorde pushed a commit to ros2/geometry2 that referenced this pull request Sep 4, 2023
@MatthijsBurgh
Remove 'efficient copy' prints (#625)
4b84838 
Matching ros/geometry2#530
mergify bot pushed a commit to ros2/geometry2 that referenced this pull request Sep 4, 2023
@MatthijsBurgh @mergify
Remove 'efficient copy' prints (#625)
48e59b6 
Matching ros/geometry2#530

(cherry picked from commit 4b84838)
mergify bot pushed a commit to ros2/geometry2 that referenced this pull request Sep 4, 2023
@MatthijsBurgh @mergify
Remove 'efficient copy' prints (#625)
26bb4be 
Matching ros/geometry2#530

(cherry picked from commit 4b84838)
ahcorde pushed a commit to ros2/geometry2 that referenced this pull request Sep 5, 2023
@mergify @MatthijsBurgh
Remove 'efficient copy' prints (#625) (#627)
5fa9318 
Matching ros/geometry2#530

(cherry picked from commit 4b84838)

Co-authored-by: Matthijs van der Burgh <matthijs.vander.burgh@live.nl>
ahcorde pushed a commit to ros2/geometry2 that referenced this pull request Sep 5, 2023
@mergify @MatthijsBurgh
Remove 'efficient copy' prints (#625) (#626)
c723256 
Matching ros/geometry2#530

(cherry picked from commit 4b84838)

Co-authored-by: Matthijs van der Burgh <matthijs.vander.burgh@live.nl>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@tfoote tfoote tfoote approved these changes

@MatthijsBurgh MatthijsBurgh MatthijsBurgh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jlunenburg @MatthijsBurgh @tfoote