Style fixes from ros2 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
sloretz
reviewed
Feb 27, 2018
| @@ -30,6 +30,10 @@ target_link_libraries(${PROJECT_NAME} | |||
| ${TinyXML_LIBRARIES} ${orocos_kdl_LIBRARIES} ${catkin_LIBRARIES} | |||
| ) | |||
|
|
|||
| if(WIN32) | |||
| target_compile_definitions(${PROJECT_NAME} PRIVATE "KDL_PARSER_BUILDING_DLL") | |||
There was a problem hiding this comment.
Same basic idea as ros/urdf#11, where William's feedback is interesting. I can open an issue here as well.
kdl_parser/src/check_kdl_parser.cpp
Outdated
|
|
||
| void printLink(const SegmentMap::const_iterator& link, const std::string& prefix) | ||
| void printLink(const KDL::SegmentMap::const_iterator & link, const std::string & prefix) |
There was a problem hiding this comment.
If qualifying with KDL:: then should using namespace KDL; online 45 be deleted?
There was a problem hiding this comment.
Good call, done now.
kdl_parser/test/test_inertia_rpy.cpp
Outdated
| * POSSIBILITY OF SUCH DAMAGE. | ||
| *********************************************************************/ | ||
|
|
||
| /* Author: Wim Meeussen */ |
There was a problem hiding this comment.
The author of this file looks like it might be @jacquelinekay in ed6237c
There was a problem hiding this comment.
Yeah, good call. That was a cut-n-paste from elsewhere in the library, but fixed now.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
sloretz
approved these changes
Mar 16, 2018
sloretz
pushed a commit
that referenced
this pull request
Mar 29, 2018
* Style fixes (these can go to upstream kdl_parser) Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Windows compatibility. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty much what it says on the tin. Import some style fixes from https://github.com/ros2/kdl_parser to reduce the difference between them. Should be no functional change.