Conversation
from python_qt_binding.QtWidgets import QLineEdit | ||
from python_qt_binding.QtWidgets import QVBoxLayout | ||
from python_qt_binding.QtWidgets import QSlider | ||
from python_qt_binding.QtWidgets import QWidget |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: alpha-ordering
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update joint_state_publisher
Code changes look good to me. Thanks for working on it! It might be better for someone like @DLu (or someone else who uses it regularly) to give it a test drive. I'd have to have a look at how it behaves now to compare. |
I just noticed a few bugs with the "randomize" button. Taking a look now. |
ok, it's now free of all new bugs that I'm aware of :) |
Forgot to push, I was referring to 7ebfc18 |
@wjwwood I talked to David and he said he was fine with us merging this if you think it looks ok, even though he hasn't taken a close look at it. |
@jacquelinekay it's fine by me. So long as you think it works basically the same as before. |
It works the same as far as I can tell; I'll deal with complaints as they come in. |
Fixes #67 by migrating from wxWidgets to qt. I tried to keep the translation faithful and not introduce new behavior or functionality.
This should also fix the many build failures on the Kinetic build farm for joint_state_publisher, so I'd like to get it merged soon.
Can someone who likes Python and Qt give a review? @ros/ros_team, @DLu, @ablasdel or whoever is available...
suggested testing (I could make a launchfile for anyone who's super lazy):
My workflow for this right now is to use shadow-fixed on a Xenial vm and only build the joint_state_publisher package, e.g. with
catkin_make_isolated --only-pkg-with-deps...
. That way the only dependencies I need to bring in are rospy, sensor_msgs. and python_qt_binding. But a few other things are needed for full testing (rosparam, rostopic).where is a valid urdf with one or more non-fixed joints:
try clicking the buttons, moving the slider, viewing the rostopic output to see that the joint states are consistent, etc.