Skip to content
This repository has been archived by the owner on Aug 3, 2020. It is now read-only.

Migrate qt #128

Merged
merged 6 commits into from Apr 12, 2016
Merged

Migrate qt #128

merged 6 commits into from Apr 12, 2016

Conversation

jacquelinekay
Copy link
Contributor

Fixes #67 by migrating from wxWidgets to qt. I tried to keep the translation faithful and not introduce new behavior or functionality.

This should also fix the many build failures on the Kinetic build farm for joint_state_publisher, so I'd like to get it merged soon.

Can someone who likes Python and Qt give a review? @ros/ros_team, @DLu, @ablasdel or whoever is available...

suggested testing (I could make a launchfile for anyone who's super lazy):

My workflow for this right now is to use shadow-fixed on a Xenial vm and only build the joint_state_publisher package, e.g. with catkin_make_isolated --only-pkg-with-deps.... That way the only dependencies I need to bring in are rospy, sensor_msgs. and python_qt_binding. But a few other things are needed for full testing (rosparam, rostopic).

where is a valid urdf with one or more non-fixed joints:

rosparam set robot_description -t <urdf>
rosrun joint_state_publisher joint_state_publisher 
(in another terminal)
rostopic echo "joint_states"

try clicking the buttons, moving the slider, viewing the rostopic output to see that the joint states are consistent, etc.

from python_qt_binding.QtWidgets import QLineEdit
from python_qt_binding.QtWidgets import QVBoxLayout
from python_qt_binding.QtWidgets import QSlider
from python_qt_binding.QtWidgets import QWidget
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: alpha-ordering

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wjwwood
Copy link
Member

wjwwood commented Apr 11, 2016

Code changes look good to me. Thanks for working on it!

It might be better for someone like @DLu (or someone else who uses it regularly) to give it a test drive. I'd have to have a look at how it behaves now to compare.

@jacquelinekay
Copy link
Contributor Author

I just noticed a few bugs with the "randomize" button. Taking a look now.

@jacquelinekay
Copy link
Contributor Author

ok, it's now free of all new bugs that I'm aware of :)

@jacquelinekay
Copy link
Contributor Author

Forgot to push, I was referring to 7ebfc18

@jacquelinekay
Copy link
Contributor Author

@wjwwood I talked to David and he said he was fine with us merging this if you think it looks ok, even though he hasn't taken a close look at it.

@wjwwood
Copy link
Member

wjwwood commented Apr 12, 2016

@jacquelinekay it's fine by me. So long as you think it works basically the same as before.

@jacquelinekay
Copy link
Contributor Author

It works the same as far as I can tell; I'll deal with complaints as they come in.

@jacquelinekay jacquelinekay merged commit 8c6cf98 into kinetic-devel Apr 12, 2016
@clalancette clalancette deleted the migrate_qt branch July 27, 2017 21:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

joint_state_publisher depends on wxpython
2 participants