add roscd, rosls support #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
reviewed
Mar 15, 2019
tools/rosbash/scripts/findpath.py
Outdated
| reldir = os.path.sep.join(parameters[1:len(parameters)]) | ||
| else: | ||
| if len(argv) <2 or argv[1] != 'forceeval': | ||
| print (ERROR_PREFIX + package_name) |
There was a problem hiding this comment.
Please remove the space before the open parenthesis. The error message Error: <pkgname> doesn't seem very helpful. Also error messages should be printed to stderr.
Same below.
There was a problem hiding this comment.
thanks for pointing this out, updated to print to stderr
tools/rosbash/CMakeLists.txt
Outdated
| @@ -8,6 +8,9 @@ install(FILES rosbash rosfish rostcsh roszsh | |||
| if (WIN32) | |||
| install(PROGRAMS scripts/rosrun.bat | |||
| DESTINATION ${CATKIN_GLOBAL_BIN_DESTINATION}) | |||
|
|
|||
| install(PROGRAMS scripts/findpath.py scripts/roscd.bat scripts/rosls.bat | |||
There was a problem hiding this comment.
The filename findpath sounds very generic. How about renaming it to rosfindpath?
Nitpick: please remove one of the two spaces after PROGRAMS.
There was a problem hiding this comment.
thanks for the name suggestion, updated to rosfindpath, removed extra space
|
Thanks for the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
roscd,roslssupport by following the logic in ros/rosbashalso add Python implementation for
_ros_location_findand_ros_decode_pathon Windows to remove dependency on Linux shell features