Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated use of "find" #33

Closed
cottsay opened this issue Sep 13, 2013 · 7 comments

Comments

Projects
None yet
4 participants
@cottsay
Copy link
Member

commented Sep 13, 2013

rosbash uses "+111" as a -perm argument to find, and I'm pretty sure +111 is used in a few other places as well.

Using "+" in perm has been deprecated in find for over 8 years, and was completely removed in new versions of find. (see man find)

This causes rosrun to not function AT ALL in Fedora 19+.

Might I suggest using "-111" instead?

@dirk-thomas

This comment has been minimized.

Copy link
Member

commented Sep 14, 2013

According to the documentation (http://linux.die.net/man/1/find) it should be -perm /111 since we want to check for any of the permission bits (and not for all), right?

@dirk-thomas

This comment has been minimized.

Copy link
Member

commented Sep 14, 2013

@wjwwood Can you please try this on OS X?

@wjwwood

This comment has been minimized.

Copy link
Member

commented Sep 14, 2013

What should I try? rosrun or....

@wjwwood

This comment has been minimized.

Copy link
Member

commented Sep 14, 2013

$ find -perm /111 .
find: illegal option -- p
usage: find [-H | -L | -P] [-EXdsx] [-f path] path ... [expression]
       find [-H | -L | -P] [-EXdsx] -f path [path ...] [expression]
@wjwwood

This comment has been minimized.

Copy link
Member

commented Sep 14, 2013

$ find . -perm /111
find: -perm: /111: illegal mode string
@cottsay

This comment has been minimized.

Copy link
Member Author

commented Sep 14, 2013

So it looks like unix takes '-' or '/' or nothing, and OS X takes '-' or '+'. This reminds me of the "which" issues we had several months ago...

@dirk-thomas yes, you're right, -perm /111 would be the matching behavior.

@ghost ghost assigned gerkey and dirk-thomas Oct 3, 2013

dirk-thomas added a commit that referenced this issue Oct 3, 2013

Merge pull request #37 from ros/find_perm
use platform dependent argument for 'find -perm' (fix #33)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.