Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix environment variable creation for fish shell #171

Merged
merged 1 commit into from Feb 21, 2018

Conversation

Projects
None yet
2 participants
@TiagoSMarques
Copy link
Contributor

commented Feb 21, 2018

Fixed compiling error on line 356 off the rosfish script.

@TiagoSMarques TiagoSMarques changed the title Environment variable for fish shell Fix environment variable creation for fish shell Feb 21, 2018

@dirk-thomas dirk-thomas added the bug label Feb 21, 2018

@dirk-thomas

This comment has been minimized.

Copy link
Member

commented Feb 21, 2018

The patch looks good to me. Thank you for addressing the problem and making a contribution.

@aclough FYI since you originally created the file in #77.

@dirk-thomas dirk-thomas merged commit 9585a29 into ros:kinetic-devel Feb 21, 2018

3 checks passed

Kpr__ros__ubuntu_xenial_amd64 Build finished.
Details
Lpr__ros__ubuntu_xenial_amd64 Build finished.
Details
Mpr__ros__ubuntu_bionic_amd64 Build finished.
Details

@amiller27 amiller27 referenced this pull request Mar 13, 2018

Merged

Fix rosfish #172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.