rosunit python 3 support #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address ros#158 by explicitly decoding to utf-8 before writing to stream.
|
Please avoid any unrelated whitespace changes. |
|
Sorry. My text editor fixes those mistakes automatically. Reverted. |
I know it is annoying 😞 Once we get close to Indigo being EOLed we hopefully have only a single branch to maintain and can cleanup a lot of the code (without having to worry about backporting patches). Thanks for the patch. |
|
Can I request a tagged release that includes this patch please? |
|
It will likely be January until I get to do ROS 1 patch releases. |
nim65s
added a commit
to nim65s/robotpkg
that referenced
this pull request
May 30, 2020
to fix in rosunit / Python 3:
File "$ROBOTPKG_BASE/lib/python3.8/site-packages/rosunit/xmlrunner.py", line 202, in print_report
stream.write(ET.tostring(self.xml(time_taken, out, err).getroot(), encoding='utf-8', method='xml'))
TypeError: write() argument must be str, not bytes
ref ros/ros#190
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #158 by explicitly decoding to utf-8 before writing to stream.
This is a typical Python 2 -> 3 issue. Before this fix, Python 2 would return a
strand Python 3 would returnbytes.bytesis not supported for writing to streams like stdout in Python 3.This fix explicitly decodes to utf-8 before writing, so in Python 2 we're writing a
unicodeobject and in Python 3 we're writing astrobject.