Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add roscd, rosls support #210

Merged
merged 3 commits into from Mar 18, 2019

Conversation

Projects
None yet
3 participants
@kejxu
Copy link
Contributor

commented Mar 5, 2019

add roscd, rosls support by following the logic in ros/rosbash

also add Python implementation for _ros_location_find and _ros_decode_path on Windows to remove dependency on Linux shell features

reldir = os.path.sep.join(parameters[1:len(parameters)])
else:
if len(argv) <2 or argv[1] != 'forceeval':
print (ERROR_PREFIX + package_name)

This comment has been minimized.

Copy link
@dirk-thomas

dirk-thomas Mar 15, 2019

Member

Please remove the space before the open parenthesis. The error message Error: <pkgname> doesn't seem very helpful. Also error messages should be printed to stderr.

Same below.

This comment has been minimized.

Copy link
@kejxu

kejxu Mar 18, 2019

Author Contributor

thanks for pointing this out, updated to print to stderr

@@ -8,6 +8,9 @@ install(FILES rosbash rosfish rostcsh roszsh
if (WIN32)
install(PROGRAMS scripts/rosrun.bat
DESTINATION ${CATKIN_GLOBAL_BIN_DESTINATION})

install(PROGRAMS scripts/findpath.py scripts/roscd.bat scripts/rosls.bat

This comment has been minimized.

Copy link
@dirk-thomas

dirk-thomas Mar 15, 2019

Member

The filename findpath sounds very generic. How about renaming it to rosfindpath?

Nitpick: please remove one of the two spaces after PROGRAMS.

This comment has been minimized.

Copy link
@kejxu

kejxu Mar 18, 2019

Author Contributor

thanks for the name suggestion, updated to rosfindpath, removed extra space

@dirk-thomas

This comment has been minimized.

Copy link
Member

commented Mar 18, 2019

Thanks for the patch.

@dirk-thomas dirk-thomas merged commit 496184d into ros:kinetic-devel Mar 18, 2019

3 checks passed

Kpr__ros__ubuntu_xenial_amd64 Build finished.
Details
Lpr__ros__ubuntu_xenial_amd64 Build finished.
Details
Mpr__ros__ubuntu_bionic_amd64 Build finished.
Details

@kejxu kejxu deleted the kejxu:add_roscd_rosls_support branch Mar 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.