Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rosbash: exclude files when completing roslaunch args #211

Conversation

Projects
None yet
2 participants
@christophebedard
Copy link
Contributor

commented Mar 8, 2019

This changes roslaunch-complete so that it excludes files/directories when completing launch file args.

I stumbled upon this FIXME while looking at ros/ros_comm#1300 and thought I'd submit this.

Here's a quick example. Previously:

$ source devel/setup.bash
$ roslaunch tracecompass_ros_testcases pub_sub.launch <tab>
build//              latching             num_pubs             src_nobuild//        .ycm_extra_conf.pyc
devel//              logs//               src//                .ycm_extra_conf.py

Now:

$ source devel/setup.bash
$ roslaunch tracecompass_ros_testcases pub_sub.launch <tab>
latching  num_pubs

I tested to make sure it doesn't affect anything else, but I'd appreciate if someone else could confirm.

rosbash: exclude files when completing roslaunch args
This changes roslaunch-complete so that it excludes files/directories
when completing launch file args.
@dirk-thomas

This comment has been minimized.

Copy link
Member

commented Mar 8, 2019

Thanks for the patch.

@dirk-thomas dirk-thomas merged commit 28b5778 into ros:kinetic-devel Mar 8, 2019

3 checks passed

Kpr__ros__ubuntu_xenial_amd64 Build finished.
Details
Lpr__ros__ubuntu_xenial_amd64 Build finished.
Details
Mpr__ros__ubuntu_bionic_amd64 Build finished.
Details

@christophebedard christophebedard deleted the christophebedard:rosbash-roslaunch-complete-exclude-files branch Jun 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.