Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix variable name (from $arg to $argv) in rosfish #279

Merged
merged 1 commit into from Mar 25, 2021
Merged

Fix variable name (from $arg to $argv) in rosfish #279

merged 1 commit into from Mar 25, 2021

Conversation

eduidl
Copy link
Contributor

@eduidl eduidl commented Mar 16, 2021

Completion does not work well due to this bug.

ref: #262

@eduidl eduidl mentioned this pull request Mar 16, 2021
Merged
jacobperron
jacobperron approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@jacobperron jacobperron merged commit a8851ec into ros:noetic-devel Mar 25, 2021
@eduidl eduidl deleted the bugfix/fish-argv branch March 26, 2021 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eduidl @jacobperron