Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error message and return code when invalid path passed to rospd. #30

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@mikepurvis
Copy link
Member

commented Aug 23, 2013

Increases the scriptability of rospd to have it return 1 (like roscd) when the package can't be found.

@mikepurvis

This comment has been minimized.

Copy link
Member Author

commented Sep 9, 2013

Now that hydro is released, would it make more sense to provide a PR for hydro instead?

@dirk-thomas

This comment has been minimized.

Copy link
Member

commented Sep 9, 2013

If you are fine with this only be addressed in Hydro you could provide a pull request against Hydro instead of Groovy. But if it should be changed for both this pull request is fine - it would be cherry-picked for Hydro after being merged.

Could you describe briefly some invocations you tried to check the behaviour (that would make it easier for me to validate the changes - besides reading the diff)? I will look at this in a couple of days.

@mikepurvis

This comment has been minimized.

Copy link
Member Author

commented Sep 9, 2013

Of course:

source /opt/ros/groovy/setup.bash
source ~/ros/tools/rosbash/rosbash
rospd roscpp  # *
echo $?    # expect 0
rospd foo  # expect "No such package"
echo $?    # expect 1
rosd       # expect same output as *
popd       # expect to return to where you started.
@dirk-thomas

This comment has been minimized.

Copy link
Member

commented Oct 3, 2013

Your pull request breaks the behavior of invoking rospd without arguments. Currently it toggles between the last two folders. With your patch it says "No such package".

I created a fixed pull request: #38. Can you please confirm that this one works for you too?

@dirk-thomas dirk-thomas closed this Oct 3, 2013

dirk-thomas added a commit that referenced this pull request Oct 3, 2013

Merge pull request #38 from ros/rospd
fix return code for rospd for invalid package names (fix #30)

@ghost ghost assigned dirk-thomas Oct 3, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.