Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rostopic autocompletion for published topics, msg-type and YAML #64

Merged
merged 1 commit into from Aug 3, 2014

Conversation

Projects
None yet
3 participants
@bajo
Copy link
Contributor

commented Jul 30, 2014

This should fix parts of issue #48 rosbash: zsh auto-completion issues

@dirk-thomas

This comment has been minimized.

Copy link
Member

commented Jul 30, 2014

@wjwwood can you please try this on OSX?

@wjwwood

This comment has been minimized.

Copy link
Member

commented Jul 30, 2014

Working on it.

@wjwwood

This comment has been minimized.

Copy link
Member

commented Jul 31, 2014

@bajo what is the expected behavior before and after this patch? I am able to tab complete on zsh on my mac, but I'm not sure what exactly I am looking for.

@wjwwood

This comment has been minimized.

Copy link
Member

commented Jul 31, 2014

I will say the tab completion does look better, I just wanted a more exact list of things you expect to be fixed by this.

@bajo

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2014

@wjwwood Before the patch, at least on my machine, the tab completion did not work for the topic name, the msg-type and the data in yaml format. If you want to send a message with a type like geometry_msgs/PoseWithCovarianceStamped you need to type all the fields and the data by hand and watch out for problems with the format and escaping of data, which is kind of annoying. :)

After the patch the tab completion should be able to complete the topic name, based on the already available topics. The type of the topic is retrieved and completed, so no std_msgs/String publishing on a topic which expects something like a geometry_msgs/PoseStamped and the prototype of the message is also completed. In the prototype you can just fill in the parts of data you want to publish.

@dirk-thomas

This comment has been minimized.

Copy link
Member

commented Aug 1, 2014

Thanks for clarifying. The patch looks good.

There is one more command completion in #48 which does not yet work completely in zsh: rosrun Could I convince you to also provide a pull request for that? 😉

@wjwwood

This comment has been minimized.

Copy link
Member

commented Aug 1, 2014

+1 from me, that is what I observed, but I just wanted to make sure you didn't fix anything else I should test too.

Thanks for this!

@bajo

This comment has been minimized.

Copy link
Contributor Author

commented Aug 2, 2014

I'll have a look at that problem as well, after my weekend trip. ;)

dirk-thomas added a commit that referenced this pull request Aug 3, 2014

Merge pull request #64 from bajo/indigo-devel
rostopic autocompletion for published topics, msg-type and YAML

@dirk-thomas dirk-thomas merged commit dc18b00 into ros:indigo-devel Aug 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.