Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smarter tab-completion of rosbag in zsh #70

Closed
wants to merge 4 commits into from

Conversation

Projects
None yet
3 participants
@Enfenion
Copy link

commented Oct 30, 2014

The first commit, c94d7f7, simply cleans up existing roszsh by converting tabs to spaces and removing some out-commented code.
The second commit makes tab completion for rosbag more intelligent by completing with bag files for all commands except record which completes with the existing topics.

Sigurd M. Albrektsen added some commits Oct 30, 2014

@tfoote

This comment has been minimized.

Copy link

commented on c94d7f7 Oct 30, 2014

This only partially fixes the indentation. It's now mixed tabs and spaces. It should be all spaces.

This comment has been minimized.

Copy link
Owner

replied Oct 30, 2014

I'm sorry. I have commited a new version with only spaces and no trailing spaces.

@dirk-thomas

This comment has been minimized.

Copy link
Member

commented Nov 4, 2014

We should choose one of the following two options for this PR:

  • either limit the changes to functional patches only (which means no white space changes at all, in order to maintain the ability to easily back port future changes to other branches)
  • or reformat the entire file regarding white spaces and indentation to be consistent, this should be a separate commit from any functional changes

Currently the PR mixes functional changes (9b50ec6) with white space changes (c94d7f7 and b199559) but the resulting file is still indented inconsistently (2 vs. 4 spaces).

@Enfenion

This comment has been minimized.

Copy link
Author

commented Nov 17, 2014

The whitespace issues should be fixed by 8089b30

@dirk-thomas

This comment has been minimized.

Copy link
Member

commented Dec 9, 2014

I manually merged the changes in 2636616 and 07df4a8.

@dirk-thomas dirk-thomas closed this Dec 9, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.