Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rosbag record: Option for TCP_NODELAY #1279

Closed
alspitz opened this issue Dec 29, 2017 · 7 comments
Closed

rosbag record: Option for TCP_NODELAY #1279

alspitz opened this issue Dec 29, 2017 · 7 comments

Comments

@alspitz
Copy link
Contributor

alspitz commented Dec 29, 2017

When recording large messages such as Odometry, the messages arrive at the bag in clumps. It would be nice if rosbag record had a --tcpnodelay or --udp option to prevent this from happening.

@dirk-thomas
Copy link
Member

The TCP_NODELAY option is a publisher setting. But in the case of recording rosbag is subscribing to the topics. Therefore it can't enforce / request that option.

Therefore I don't think this feature request for rosbag is feasible. Instead whichever node is publishing the odometer messages would need to provide that option.

@alspitz
Copy link
Contributor Author

alspitz commented Dec 30, 2017

It's definitely an option that can be added to a C++ subscription: https://docs.ros.org/api/roscpp/html/classros_1_1TransportHints.html. AFAIK, there is no way to add transport hints to a C++ publisher.

@alspitz
Copy link
Contributor Author

alspitz commented Dec 30, 2017

Also, since Python subscribers can also specify TCP_NODELAY (but not UDP), it would be nice if rostopic hz had a --nodelay option as well.

@dirk-thomas
Copy link
Member

Sorry, you are right. The option can also be requested from the subscriber side.

Please consider to provide a pull request to add such an option to the rosbag record command.

@alspitz
Copy link
Contributor Author

alspitz commented Jan 2, 2018

I've created a pull request here: #1295

@alspitz
Copy link
Contributor Author

alspitz commented Jan 2, 2018

I also created a pull request for adding TCP_NODELAY to rostopic hz and delay here: #1296

@dirk-thomas
Copy link
Member

I close this issue in favor of the pending PR #1295 (to only have one open item). Thank you for working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants