Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change from Boost::signal to Boost::signals2::signal #267

Closed
tfoote opened this issue Aug 3, 2013 · 3 comments
Closed

Change from Boost::signal to Boost::signals2::signal #267

tfoote opened this issue Aug 3, 2013 · 3 comments
Assignees
@dirk-thomas
Labels
enhancement

Comments

@tfoote
Copy link
Member

tfoote commented Aug 3, 2013

In newer versions of Boost Boost.Signal has been deprecated.

William identified it here: ros/geometry#23

But in changing that I found that the underlying message_filter class exposes boost::signal in it's API.
@dirk-thomas
Copy link
Member

Since this is an API breaking change it is not happening for Groovy/Hydro but earliest for Indigo.

@trainman419
Copy link
Contributor

+1 to putting this into Indigo before boost removes it completely in a future version. This could affect compatibility with future versions of Ubuntu

Also +1 to any solution that makes the warning messages go away.

dirk-thomas added a commit that referenced this issue Mar 28, 2014
@dirk-thomas
update API to use boost::signals2 (#267)
231a457
@dirk-thomas dirk-thomas removed this from the untargeted milestone Mar 28, 2014
@dirk-thomas dirk-thomas removed the minor label Mar 28, 2014
dirk-thomas added a commit that referenced this issue Mar 31, 2014
@dirk-thomas
Merge pull request #381 from ros/switch_to_boost_signals2
b49afac 
update API to use boost::signals2 (#267)
@dirk-thomas
Copy link
Member

Done in #381.

@dirk-thomas dirk-thomas self-assigned this Mar 31, 2014
@paulbovbel paulbovbel mentioned this issue Apr 9, 2014
Closed
@tfoote tfoote mentioned this issue Apr 29, 2014
Closed
tfoote added a commit to ros/geometry that referenced this issue Apr 29, 2014
@tfoote
convert to boost signals2 following ros/ros_comm#267 Fixes #23. Requi…
3c8670a 
…res ros/geometry2#61 as well.
tfoote added a commit to ros/geometry2 that referenced this issue Apr 29, 2014
@tfoote
switch to boost signals2 following ros/ros_comm#267, blocking ros/geo…
31c7b83 
…metry#23
tfoote added a commit to ros/geometry that referenced this issue May 2, 2014
@tfoote
convert to boost signals2 following ros/ros_comm#267 Fixes #23. Requi…
de4616b 
…res ros/geometry2#61 as well.
severin-lemaignan pushed a commit to severin-lemaignan/robotpkg that referenced this issue Aug 18, 2014
[math/ros-geometry] Update to 1.11.3
946676c 
Changes since 1.9.30:

^^^^^^^^^^^^^^^^^^^^^^^^
Changelog for package tf
^^^^^^^^^^^^^^^^^^^^^^^^

1.11.3 (2014-05-07)
-------------------
* convert to boost signals2 following `ros/ros_comm#267
<https://github.com/ros/ros_comm/issues/267>`_ Fixes `#23
<https://github.com/ros/geometry/issues/23>`_. Requires
`ros/geometry2#61
<https://github.com/ros/geometry_experimental/issues/61>`_ as well.
* add rospy publisher queue_size argument
  `ros/ros_comm#169 <https://github.com/ros/ros_comm/issues/169>`_
* add queue_size to tf publisher
  `ros/ros_comm#169 <https://github.com/ros/ros_comm/issues/169>`_
* make rostest in CMakeLists optional (`ros/rosdistro#3010
<https://github.com/ros/rosdistro/issues/3010>`_)
* Contributors: Lukas Bulwahn, Tully Foote

1.11.2 (2014-02-25)
-------------------
* fixing test linking
* Contributors: Tully Foote

1.11.1 (2014-02-23)
-------------------

1.11.0 (2014-02-14)
-------------------
* TF uses ros::MessageEvent to get connection information
* Contributors: Kevin Watts, Tully Foote

1.10.8 (2014-02-01)
-------------------
* Port groovy-devel patch to hydro-devel
* Added rosconsole as catkin dependency for catkin_package
* Add rosconsole as runtime dependency
* Contributors: Michael Ferguson, Mirza Shah

1.10.7 (2013-12-27)
-------------------
* fix bug in tf::Matrix3x3::getEulerYPR()
  Fixes a bug in tf::Matrix3x3::getEulerYPR() implementation's handling
  of gimbal lock cases (when the new x axis aligns with the old +/-z
  axis).
* add test that demonstrated bug in tf::Matrix3x3
  tf::Matrix3x3::getEulerYPR() has a bug which returns an incorrect rpy
  for certain corner case inputs.  This test demonstrates that bug.
* Fix const correctness of tf::Vector3 rotate() method
  The method does not modify the class thus should be const.
  This has already been fixed in Bullet itself.
* add automatic tf buffer cleaning on bag loop for python
  This logic was already implemented for c++
  but not for the python module.
* Contributors: Acorn Pooley, Timo Rohling, Tully Foote, v4hn

1.10.6 (2013-08-28)
-------------------
* switching to wrapper scripts which will provide a deprecation warning for `#3
<https://github.com/ros/geometry/issues/3>`_
* add missing roswtf dependency to really export the plugin (fix `#27
<https://github.com/ros/geometry/issues/27>`_)
* Update listener.py
  Fix the tf listener service exception in rospy. See:
  http://answers.ros.org/question/10777/service-exception-using-tf-listener-in-rospy/
* Fix MessageFilter race condition
  If MessageFilter does not explicitly stop its callback timer when it's
  being destroyed, there is a race condition when that timer is processed in
  a callback queue run by a different thread.  Specifically,
  maxRateTimerCallback() may be called after messages_mutex_ has been
  destroyed, causing a unrecoverable error.

1.10.5 (2013-07-19)
-------------------
* tf: export dependency on tf2_ros
  Fixes `#21 <https://github.com/ros/geometry/issues/21>`_
* added run dependency on graphviz
  closes `#19 <https://github.com/ros/geometry/issues/19>`_

1.10.4 (2013-07-11)
-------------------
* fixing erase syntax
* resolving ros/geometry#18 using implementation
added in tf2::BufferCore, adding dependency on next version of tf2 for this

1.10.3 (2013-07-09)
-------------------
* fixing unittest for new resolve syntax

1.10.2 (2013-07-09)
-------------------
* strip leading slashes in resolve, and also any time a method is passed from
tf to tf2 assert the leading slash is stripped as well.  tf::resolve with two
arguments will end up with foo/bar instead of /foo/bar.  Fixes
ros/geometry2#12
* added two whitespaces to make message_filter compile with c++11
  more on this here:
  http://stackoverflow.com/questions/10329942/error-unable-to-find-string-literal-operator-slashes
* using CATKIN_ENABLE_TESTING to optionally configure tests in tf

1.10.1 (2013-07-05)
-------------------
* updating dependency requirement to tf2_ros 0.4.3
* removing unused functions
  removing unused private methods
  removing ``max_extrapolation_distance_``
  removing unused data storage _frameIDs frameIDS_reverse ``frame_authority_``
  removing cache_time from tf, passing through method to tf2 buffer_core
  removing unused variables ``frames_`` and ``frame_mutex_`` and
  ``interpolating_``
  removing unused mutex and transformchanged signaling
  commenting on deprecation of MAX_EXTRAPOLATION_DISTANCE

1.10.0 (2013-07-05)
-------------------
* adding versioned dependency on recent geometry_experimental changes
* fixing test dependencies
* fixing callbacks for message filters
* remove extra invalid comment
* dedicated thread logic all implemented
* removing commented out code
* mostly completed conversion of tf::TransformListener to use tf2 under the
hood
* lookuptwist working
* tf::Transformer converted to use tf2::Buffer under the hood.  passing
tf_unittest.cpp
* making tf exceptions typedefs of tf2 exceptions for compatability
* first stage of converting Transformer to Buffer
* switching to use tf2's TransformBroadcaster
* adding dependency on tf2_ros to start moving over contents
* fixing unit tests
daju1 pushed a commit to daju1-ros/tf that referenced this issue Oct 28, 2016
@tfoote
most of a patch for ros/geometry#23 but blocked by ros/ros_comm#267
f66ebc7
daju1 pushed a commit to daju1-ros/geometry-experimental that referenced this issue Oct 28, 2016
@tfoote
most of a patch for ros/geometry#23 but blocked by ros/ros_comm#267
50cf3e1
rsinnet pushed a commit to MisoRobotics/ros_comm that referenced this issue Jun 19, 2017
@dirk-thomas
Merge pull request ros#381 from ros/switch_to_boost_signals2
214a22b 
update API to use boost::signals2 (ros#267)
kheaactua pushed a commit to kheaactua/conan-tf2 that referenced this issue Dec 22, 2018
@tfoote
switch to boost signals2 following ros/ros_comm#267, blocking ros/geo…
e2601a0 
…metry#23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dirk-thomas dirk-thomas

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@trainman419 @tfoote @dirk-thomas