Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[message_filters] Fast approximate time synchronization in message_filters (pure python) #802

Merged
merged 3 commits into from
Aug 8, 2016
Merged

[message_filters] Fast approximate time synchronization in message_filters (pure python) #802

merged 3 commits into from
Aug 8, 2016

Conversation

wkentaro
Copy link
Contributor

@wkentaro wkentaro commented May 5, 2016 •
edited

Closes #800

Result

% rostopic hz /join_strings/output
subscribed to [/join_strings/output]
average rate: 0.995
        min: 1.005s max: 1.005s std dev: 0.00000s window: 2
average rate: 0.932
        min: 1.005s max: 1.141s std dev: 0.06805s window: 3
average rate: 0.953
        min: 1.002s max: 1.141s std dev: 0.06469s window: 4
average rate: 0.963
        min: 1.002s max: 1.141s std dev: 0.05930s window: 5
average rate: 0.950
        min: 1.002s max: 1.141s std dev: 0.06099s window: 6
average rate: 0.936
        min: 1.002s max: 1.144s std dev: 0.06516s window: 7
average rate: 0.944
        min: 1.002s max: 1.144s std dev: 0.06444s window: 8
average rate: 0.948
        min: 1.002s max: 1.144s std dev: 0.06143s window: 9
average rate: 0.953
        min: 1.002s max: 1.144s std dev: 0.05997s window: 10
no new messages
average rate: 0.955
        min: 1.002s max: 1.144s std dev: 0.05706s window: 11
average rate: 0.958
        min: 1.002s max: 1.144s std dev: 0.05597s window: 12
average rate: 0.962
        min: 1.002s max: 1.144s std dev: 0.05481s window: 13
average rate: 0.964
        min: 1.002s max: 1.144s std dev: 0.05361s window: 14
average rate: 0.967
        min: 1.002s max: 1.144s std dev: 0.05243s window: 15
average rate: 0.969
        min: 1.002s max: 1.144s std dev: 0.05129s window: 16
average rate: 0.970
        min: 1.002s max: 1.144s std dev: 0.05019s window: 17
average rate: 0.972
        min: 1.002s max: 1.144s std dev: 0.04914s window: 18
average rate: 0.973
        min: 1.002s max: 1.144s std dev: 0.04802s window: 19
average rate: 0.974
        min: 1.002s max: 1.144s std dev: 0.04697s window: 20

@wkentaro wkentaro mentioned this pull request May 5, 2016
Closed
@wkentaro wkentaro changed the title [message_filters] Fast approximate time synchronization in message_filters [message_filters] Fast approximate time synchronization in message_filters (pure python) May 5, 2016
@wkentaro wkentaro mentioned this pull request May 5, 2016
Closed
@dirk-thomas
Copy link
Member

@ros-pull-request-builder retest this please

@wkentaro wkentaro force-pushed the fast-message-filter-purepython branch from 5d519b5 to d8e15f0 Compare May 7, 2016 00:16
@wkentaro wkentaro force-pushed the fast-message-filter-purepython branch 4 times, most recently from 1a40796 to fad3171 Compare May 19, 2016 12:02
@wkentaro
Copy link
Contributor Author

I removed the debugging lines, please review and give me feedback when you have time.

dirk-thomas
dirk-thomas reviewed Jun 3, 2016
View reviewed changes
utilities/message_filters/src/message_filters/__init__.py

def add(self, msg, my_queue):
def add(self, msg, my_queue, my_queue_index):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes existing public API and would therefore break existing code. I don't think this is feasible for an already released ROS distro.

@wkentaro wkentaro force-pushed the fast-message-filter-purepython branch from e562bf0 to 1740d7e Compare June 4, 2016 15:10
@wkentaro
Copy link
Contributor Author

wkentaro commented Jun 6, 2016

Updated.

@wkentaro
Copy link
Contributor Author

wkentaro commented Aug 5, 2016

Could you please give me some comments?

@dirk-thomas
Copy link
Member

I am sorry for the late response but I currently have to focus on a different project and don't have much time to review ROS tickets.

The patch looks good to me. Thank you for iterating on it.

@dirk-thomas dirk-thomas merged commit 4632a58 into ros:kinetic-devel Aug 8, 2016
@dirk-thomas dirk-thomas mentioned this pull request Aug 8, 2016
Closed
@wkentaro wkentaro deleted the fast-message-filter-purepython branch August 9, 2016 00:55
@wkentaro
Copy link
Contributor Author

wkentaro commented Aug 9, 2016

I see. Thank you.

@dirk-thomas dirk-thomas mentioned this pull request Mar 1, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wkentaro @dirk-thomas