Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use python defined error codes rather than hardcoded integers #1174

Merged
merged 1 commit into from Oct 4, 2017

Conversation

Projects
None yet
4 participants
@mikaelarguedas
Copy link
Contributor

commented Sep 30, 2017

follow up of ros/genpy#89. Use python defined error codes everywhere

@mikepurvis

This comment has been minimized.

Copy link
Member

commented Sep 30, 2017

Looks like no functional change, just rationalization. 👍

@dirk-thomas dirk-thomas merged commit 1ba470c into ros:lunar-devel Oct 4, 2017

1 check passed

Lpr__ros_comm__ubuntu_xenial_amd64 Build finished.
Details

@mikaelarguedas mikaelarguedas deleted the mikaelarguedas:litteral_errorcodes branch Oct 6, 2017

@guillaumeautran

This comment has been minimized.

Copy link
Contributor

commented on clients/rospy/src/rospy/impl/tcpros_base.py in 423209e Nov 9, 2017

Looks like there is a typo here: e.ENETUNREACH should really be errno.ENETUNREACH

This comment has been minimized.

Copy link
Member

replied Nov 9, 2017

Ref #1226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.