Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
return an error status on error in rosbag #1257
@phil-marble it typically takes a few days for someone to have time to review and either merge this or give you feedback on what needs to change. After merging, it will take a few weeks to a month to get into the public
wjwwood left a comment
The change looks reasonable to me.
I only identified this line which might also benefit from using
While this line (and few others that follow it) could (probably should) be converted to use
After a quick scan I didn't see anything else that needed doing related to returning an error code when there's a problem.
I'll leave it up to one of the actual maintainers to review and approve this change however.