Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
So, I have a migration rule that induces this bug. However, I cannot provide that information publicly.
I can describe in detail what happens. It appears as if around line 549, if the
Then, there is a check:
if rulechain.rename and (r.order >= rulechain.chain[-1]):
which crashes because there are no rules in the rule chain, only a single rename. If you look right before the diff in the file, you can see all of the other checks, ensure
All I did was make the if-check match the debug print statement it encloses and the offending file works just fine. I believe this is a copy and paste error with line 752.
I was able to reproduce the issue with two bag migration rules: one which renames message
This currently raises
Changes since 1.8.15: 1.9.46 (2013-06-18) ------------------- * add dependency on roslisp (`#240 <https://github.com/ros/ros_comm/issues/240>`_) * fix crash in bag migration (`#239 <https://github.com/ros/ros_comm/issues/239>`_) * add CMake function roslaunch_add_file_check() (`#241 <https://github.com/ros/ros_comm/issues/241>`_) * fix rosnode_ping to check if new node uri is valid before using it (`#235 <https://github.com/ros/ros_comm/issues/235>`_) 1.9.45 (2013-06-06) ------------------- * improve handling of UDP transport, when fragmented packets are lost or arive out-of-order the connection is not dropped anymore, onle a single message is lost (`#226 <https://github.com/ros/ros_comm/issues/226>`_) * fix missing generation of constant definitions for services (`ros/gencpp#2 <https://github.com/ros/gencpp/issues/2>`_) * fix restoring thread context when callback throws an exception (`#219 <https://github.com/ros/ros_comm/issues/219>`_) * fix calling PollManager::shutdown() repeatedly (`#217 <https://github.com/ros/ros_comm/issues/217>`_) * add missing run_depend on python-yaml * allow configuration of ports for XML RPCs and TCP ROS * fix race condition where rospy subscribers do not connect to all publisher * fix closing and deregistering connection when connect fails (`#128 <https://github.com/ros/ros_comm/issues/128>`_) * fix log level of RosOutHandler (`#210 <https://github.com/ros/ros_comm/issues/210>`_) * added option '--duration' to 'rosbag play' (`#121 <https://github.com/ros/ros_comm/issues/121>`_) * fix missing newlines in rosbag error messages (`#237 <https://github.com/ros/ros_comm/issues/237>`_) * fix flushing for tools like 'rosbag compress' (`#237 <https://github.com/ros/ros_comm/issues/237>`_) * add warnings for obviously wrong environment variables ROS_HOSTNAME and ROS_IP (`#134 <https://github.com/ros/ros_comm/issues/134>`_) * fix exception on netifaces.ifaddresses() (`#211 <https://github.com/ros/ros_comm/issues/211>`_, `#213 <https://github.com/ros/ros_comm/issues/213>`_) (regression from 1.9.42) * modify rosnode_ping to check for changed node uri if connection is refused (`#221 <https://github.com/ros/ros_comm/issues/221>`_) * allow passing arguments to add_rostest(ARGS ...) (`#232 <https://github.com/ros/ros_comm/issues/232>`_) * modified roslaunch $(find PKG) to consider path behind it for resolve strategy (`#233 <https://github.com/ros/ros_comm/pull/233>`_) * add boolean attribute 'subst_value' to rosparam tag in launch files (`#218 <https://github.com/ros/ros_comm/issues/218>`_) * add command line parameter to print out launch args * fix missing import in arg_dump.py * fix template syntax for signal_.template addCallback() to work with Intel compiler 1.9.44 (2013-03-21) ------------------- * fix install destination for dll's under Windows * fix various issues on Windows (`#189 <https://github.com/ros/ros_comm/issues/189>`_) * fix 'roslaunch --files' with non-unique anononymous ids (`#186 <https://github.com/ros/ros_comm/issues/186>`_) * fix ROS_MASTER_URI for Windows 1.9.43 (2013-03-13) ------------------- * implement process killer for Windows * fix exports of message filter symbols for Windows 1.9.42 (2013-03-08) ------------------- * improve speed of message generation in dry packages (`#183 <https://github.com/ros/ros_comm/issues/183>`_) * fix roscpp service call deadlock (`#149 <https://github.com/ros/ros_comm/issues/149>`_) * fix freezing service calls when returning false (`#168 <https://github.com/ros/ros_comm/issues/168>`_) * fix error message publishing wrong message type (`#178 <https://github.com/ros/ros_comm/issues/178>`_) * fix missing explicit dependency on pthread (`#135 <https://github.com/ros/ros_comm/issues/135>`_) * fix compiler warning about wrong comparison of message md5 hashes (`#165 <https://github.com/ros/ros_comm/issues/165>`_) * make dependencies on rospy optional by refactoring RosStreamHandler to rosgraph (`#179 <https://github.com/ros/ros_comm/issues/179>`_) * added option '--duration' to 'rosrun rosbag play' (`#121 <https://github.com/ros/ros_comm/issues/121>`_) * add error message to rosbag when using same in and out file (`#171 <https://github.com/ros/ros_comm/issues/171>`_) * fix handling spaces in folder names (`ros/catkin#375 <https://github.com/ros/catkin/issues/375>`_) * replace custom code with Python module netifaces (`#130 <https://github.com/ros/ros_comm/issues/130>`_) * make dependencies on rospy optional by refactoring RosStreamHandler to rosgraph (`#179 <https://github.com/ros/ros_comm/issues/179>`_) * add option --skip-log-check (`#133 <https://github.com/ros/ros_comm/issues/133>`_) * update API doc to list raised exceptions in config.py * fix invocation of Python scripts under Windows (`#54 <https://github.com/ros/ros_comm/issues/54>`_) * fix usage of rosservice from within a launch file * fix missing run_depend on rosbag (`#179 <https://github.com/ros/ros_comm/issues/179>`_) 1.9.41 (2013-01-24) ------------------- * allow sending data exceeding 2GB in chunks (`#4049 <https://code.ros.org/trac/ros/ticket/4049>`_) * update getParam() doc (`#1460 <https://code.ros.org/trac/ros/ticket/1460>`_) * add param::get(float) (`#3754 <https://code.ros.org/trac/ros/ticket/3754>`_) * update inactive assert when publishing message with md5sum *, update related tests (`#3714 <https://code.ros.org/trac/ros/ticket/3714>`_) * fix ros master retry timeout (`#4024 <https://code.ros.org/trac/ros/ticket/4024>`_) * fix inactive assert when publishing message with wrong type (`#3714 <https://code.ros.org/trac/ros/ticket/3714>`_) * improve performance of $(find ...) 1.9.40 (2013-01-13) ------------------- * add colorization for rospy log output (`#3691 <https://code.ros.org/trac/ros/ticket/3691>`_) * fix socket polling under Windows (`#3959 <https://code.ros.org/trac/ros/ticket/3959>`_) * fix bagsort script (`#42 <https://github.com/ros/ros_comm/issues/42>`_) * fix dependent packages by pass LOG4CXX include dirs and libraries along * fix usage of variable arguments in vFormatToBuffer() function * add colorization for rospy log output (`#3691 <https://code.ros.org/trac/ros/ticket/3691>`_) * fix 'roslaunch --pid=' when pointing to ROS_HOME but folder does not exist (`#43 <https://github.com/ros/ros_comm/issues/43>`_) * fix 'roslaunch --pid=' to use shell expansion for the pid value (`#44 <https://github.com/ros/ros_comm/issues/44>`_) * fix output of 'rossrv --help' (`#3979 <https://code.ros.org/trac/ros/ticket/3979>`_) * add support for boolean in 'rostopic -p' (`#3948 <https://code.ros.org/trac/ros/ticket/3948>`_) * add checks for pip packages and rosdep * fix check for catkin_pkg * fix for thread race condition causes incorrect graph connectivity analysis