Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rosmsg does not show messages existing only in devel space #385

Merged
merged 1 commit into from May 5, 2014

Conversation

Projects
None yet
3 participants
@dirk-thomas
Copy link
Member

commented Apr 5, 2014

Initially reported here: http://answers.ros.org/question/147586/unable-to-locate-custom-action-using-rosmsg-with-catkin

This effects especially messages generated for actions.

@dirk-thomas dirk-thomas added the bug label Apr 5, 2014

@dirk-thomas

This comment has been minimized.

Copy link
Member Author

commented Apr 5, 2014

This will effectively double the search time in case of a devel space since rosmsg has to look through both spaces (source and devel). In install space the patch should be a no-op.

@tfoote

This comment has been minimized.

Copy link
Member

commented Apr 5, 2014

+1

@dirk-thomas

This comment has been minimized.

Copy link
Member Author

commented Apr 8, 2014

Since the previous search results might utilize the rospkg cache but the new additional search using catkin_pkg does not the performance might actually be worse. In http://answers.ros.org/question/147586/unable-to-locate-custom-action-using-rosmsg-with-catkin/ it is mentioned that rosmsg list goes from nearly instant result to 15-30s runtime.

@dirk-thomas

This comment has been minimized.

Copy link
Member Author

commented May 5, 2014

Based on ros/catkin@cb1e8fe the repeated crawling can be avoided which speeds up this use case significantly.

@dirk-thomas

This comment has been minimized.

Copy link
Member Author

commented May 5, 2014

In my testing the speed of rosmsg list was only slightly slower (from 0.45s to 0.55s) in a workspace with ros base built in isolation. Before the performance patch it took about 6s.

@tfoote @wjwwood Please review.

@wjwwood

This comment has been minimized.

Copy link
Member

commented May 5, 2014

+1

dirk-thomas added a commit that referenced this pull request May 5, 2014

Merge pull request #385 from ros/rosmsg_messages_from_devel_space
rosmsg does not show messages existing only in devel space

@dirk-thomas dirk-thomas merged commit cd14e5d into indigo-devel May 5, 2014

@dirk-thomas dirk-thomas deleted the rosmsg_messages_from_devel_space branch May 5, 2014

rsinnet pushed a commit to MisoRobotics/ros_comm that referenced this pull request Jun 19, 2017

Merge pull request ros#385 from ros/rosmsg_messages_from_devel_space
rosmsg does not show messages existing only in devel space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.