Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 compatibility #426

Merged
merged 1 commit into from Jun 4, 2014

Conversation

Projects
None yet
3 participants
@dirk-thomas
Copy link
Member

dirk-thomas commented Jun 4, 2014

The (hopefully) trivial parts of #358 which should not result in any regression...

@dirk-thomas

This comment has been minimized.

Copy link
Member Author

dirk-thomas commented Jun 4, 2014

@ros-pull-request-builder retest this please

@ros-pull-request-builder

This comment has been minimized.

Copy link
Member

ros-pull-request-builder commented Jun 4, 2014

Test passed.
Refer to this link for build results: http://jenkins.ros.org/job/_pull_request-indigo-ros_comm/9/

@dirk-thomas

This comment has been minimized.

Copy link
Member Author

dirk-thomas commented Jun 4, 2014

Zero regressions with Python 2.

@tfoote Please review.

@tfoote

This comment has been minimized.

Copy link
Member

tfoote commented Jun 4, 2014

It's a huge diff, but I did not see any red flags.

+1

dirk-thomas added a commit that referenced this pull request Jun 4, 2014

@dirk-thomas dirk-thomas merged commit 28787ce into indigo-devel Jun 4, 2014

1 check passed

default Merged build finished.
Details

@dirk-thomas dirk-thomas deleted the python3_simple branch Jun 4, 2014

rsinnet pushed a commit to MisoRobotics/ros_comm that referenced this pull request Jun 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.