Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 compatibility #429

Merged
merged 1 commit into from Jun 5, 2014

Conversation

Projects
None yet
3 participants
@dirk-thomas
Copy link
Member

dirk-thomas commented Jun 4, 2014

No description provided.

@dirk-thomas dirk-thomas referenced this pull request Jun 4, 2014

Closed

Python 3 compatibility #2427

15 of 15 tasks complete
@ros-pull-request-builder

This comment has been minimized.

Copy link
Member

ros-pull-request-builder commented Jun 4, 2014

Test passed.
Refer to this link for build results: http://jenkins.ros.org/job/_pull_request-indigo-ros_comm/12/

@dirk-thomas

This comment has been minimized.

Copy link
Member Author

dirk-thomas commented Jun 4, 2014

Zero regressions with Python 2.

@wjwwood Please review.

param_key = args[1]
param_val = args[2]

val = compute_param_updates(reg, param_key, param_val)

This comment has been minimized.

Copy link
@wjwwood

wjwwood Jun 4, 2014

Member

This change doesn't seem to be equivalent, it seems as though reg would have not been passed before. Is this right?

This comment has been minimized.

Copy link
@dirk-thomas

dirk-thomas Jun 4, 2014

Author Member

Yeah, looks pretty weird. But actually the test was not using the API as specified before and did not pass in a Registrations instance as it should be. So this patch should be a cleanup.

@wjwwood

This comment has been minimized.

Copy link
Member

wjwwood commented Jun 4, 2014

Other than the comment +1

dirk-thomas added a commit that referenced this pull request Jun 5, 2014

@dirk-thomas dirk-thomas merged commit 9962bb6 into indigo-devel Jun 5, 2014

1 check passed

default Merged build finished.
Details

@dirk-thomas dirk-thomas deleted the python3_well_done branch Jun 5, 2014

@dirk-thomas dirk-thomas referenced this pull request Jun 6, 2014

Closed

Python 3 compatibility #358

rsinnet pushed a commit to MisoRobotics/ros_comm that referenced this pull request Jun 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.