Add rosconsole command to change logger levels from command line #576
Conversation
There is only the rqt_logger_level command for changing the logger level for node. If you are doing remote work without an X session, you have to send service commands directly or change the logger configuration. This command line tool allows you to query and set the logger level.
|
Can one of the admins verify this patch? |
| @@ -121,3 +121,8 @@ if(CATKIN_ENABLE_TESTING) | |||
| target_link_libraries(${PROJECT_NAME}-thread_test ${PROJECT_NAME}) | |||
| endif() | |||
| endif() | |||
|
|
|||
| catkin_python_setup() | |||
There was a problem hiding this comment.
The package needs a setup.py file for this to work. You might have missed to add it to the repo.
|
This is a great new feature. I made a couple of small comments inline. The "biggest" suggestion would be to use |
|
I fixed some of the copy and paste errors and I added the setup.py file. Thanks for the feedback. With regards to argparse, I simply copied what exists in the other default ros command line tools. And at least on older systems, argparse is not part of the default python install. |
|
Actually nowadays it is part of it. Since this patch targets Indigo which implies Ubuntu Trusty which comes with Python 2.7 which includes argparse by default. Anyway you don't have to use |
| packages=['rosconsole'], | ||
| package_dir={'': 'src'}, | ||
| scripts=['scripts/rosconsole'], | ||
| requires=['genmsg', 'genpy', 'roslib', 'rospkg'] |
There was a problem hiding this comment.
Can you please explain why you used these four dependencies?
There was a problem hiding this comment.
I copied from all other default tools.
|
Please make new Python code comply with PEP8. |
Note: pep8 does allow an "increase the nominal line length from 80 to 100 characters"
|
Thanks for the contribution. I made a few small fixes and created #594 to replace this PR. |
There is only the rqt_logger_level command for changing the logger
level for node. If you are doing remote work without an X session, you
have to send service commands directly or change the logger
configuration. This command line tool allows you to query and set the
logger level.