Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Add rosconsole command to change logger levels from command line #576
Conversation
There is only the rqt_logger_level command for changing the logger level for node. If you are doing remote work without an X session, you have to send service commands directly or change the logger configuration. This command line tool allows you to query and set the logger level.
|
Can one of the admins verify this patch? |
| @@ -121,3 +121,8 @@ if(CATKIN_ENABLE_TESTING) | |||
| target_link_libraries(${PROJECT_NAME}-thread_test ${PROJECT_NAME}) | |||
| endif() | |||
| endif() | |||
|
|
|||
| catkin_python_setup() | |||
dirk-thomas
Mar 12, 2015
Member
The package needs a setup.py file for this to work. You might have missed to add it to the repo.
The package needs a setup.py file for this to work. You might have missed to add it to the repo.
| catkin_python_setup() | ||
|
|
||
| catkin_install_python(PROGRAMS scripts/rosconsole | ||
| DESTINATION ${CATKIN_PACKAGE_BIN_DESTINATION}) |
dirk-thomas
Mar 12, 2015
Member
It probably makes sense to install this into the global bin folder rather then the package-specific libexec folder to be able to run it without rosrun. Instead of using catkin_install_python you can list it as a script in the setup.py file.
It probably makes sense to install this into the global bin folder rather then the package-specific libexec folder to be able to run it without rosrun. Instead of using catkin_install_python you can list it as a script in the setup.py file.
| #!/usr/bin/env python | ||
|
|
||
| # make sure we aren't using floor division | ||
| from __future__ import division, print_function |
dirk-thomas
Mar 12, 2015
Member
It looks like you need neither of these two.
It looks like you need neither of these two.
| if argv is None: | ||
| argv=sys.argv | ||
| # filter out remapping arguments in case we are being invoked via roslaunch | ||
| argv = rospy.myargv(argv) |
dirk-thomas
Mar 12, 2015
Member
Since all nodes will "race" when being invoked through roslaunch it might not be a good idea to use this script to try to change the logger level since the targeted node might not have started fast enough.
Since all nodes will "race" when being invoked through roslaunch it might not be a good idea to use this script to try to change the logger level since the targeted node might not have started fast enough.
cmansley
Mar 12, 2015
Author
Contributor
Do you have a suggestion to fix this in the tool? Because it would be a shame to lose out on the functionality of the tool just because of the possibility of abuse.
Do you have a suggestion to fix this in the tool? Because it would be a shame to lose out on the functionality of the tool just because of the possibility of abuse.
dirk-thomas
Mar 12, 2015
Member
You can keep this line in the patch. I just wanted to state that using it in a launch file is imo not recommended. Therefore the comment is a bit misleading.
roslaunch is not designed to handle this and will very likely not be modified to do so. We are aware of that limitation and ROS 2 will for sure address those but that won't help in ROS 1.
You can keep this line in the patch. I just wanted to state that using it in a launch file is imo not recommended. Therefore the comment is a bit misleading.
roslaunch is not designed to handle this and will very likely not be modified to do so. We are aware of that limitation and ROS 2 will for sure address those but that won't help in ROS 1.
cmansley
Mar 12, 2015
Author
Contributor
Another copy and paste artifact. I can remove the comment.
Another copy and paste artifact. I can remove the comment.
|
This is a great new feature. I made a couple of small comments inline. The "biggest" suggestion would be to use |
|
I fixed some of the copy and paste errors and I added the setup.py file. Thanks for the feedback. With regards to argparse, I simply copied what exists in the other default ros command line tools. And at least on older systems, argparse is not part of the default python install. |
|
Actually nowadays it is part of it. Since this patch targets Indigo which implies Ubuntu Trusty which comes with Python 2.7 which includes argparse by default. Anyway you don't have to use |
| packages=['rosconsole'], | ||
| package_dir={'': 'src'}, | ||
| scripts=['scripts/rosconsole'], | ||
| requires=['genmsg', 'genpy', 'roslib', 'rospkg'] |
dirk-thomas
Mar 16, 2015
Member
Can you please explain why you used these four dependencies?
Can you please explain why you used these four dependencies?
cmansley
Mar 16, 2015
Author
Contributor
I copied from all other default tools.
I copied from all other default tools.
|
Please make new Python code comply with PEP8. |
Note: pep8 does allow an "increase the nominal line length from 80 to 100 characters"
|
Thanks for the contribution. I made a few small fixes and created #594 to replace this PR. |
There is only the rqt_logger_level command for changing the logger
level for node. If you are doing remote work without an X session, you
have to send service commands directly or change the logger
configuration. This command line tool allows you to query and set the
logger level.