Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing depend on boost #24

Closed
cottsay opened this issue Jun 28, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@cottsay
Copy link
Member

commented Jun 28, 2014

My most recent Fedora builds of cpp_common [1] are not installing the boost development libraries as they did about 2 weeks ago. I don't see any changes to cpp_common that would have triggered this, so it must have been an upstream package that changed its deps or something like that.

I can't see any reason not to have cpp_common depend on boost, as it references boost headers [2].

I can confirm this on an f20 system without boost-devel by running:

mkdir -p ~/boost_test_ws/src
cd ~/boost_test_ws
rosinstall_generator --deps --tar --rosdistro indigo cpp_common > src/.rosinstall
wstool update -t src
rosdep install --from-path src --ignore-src

...and finding that boost-devel is not installed as it should be.

I have confirmed that adding boost as a run and build dependency fixes things [3] [4], but I'm not sure what caused this to begin with, so I can only suggest that as a possible fix.

Thanks,

--scott
[1] http://csc.mcs.sdsmt.edu/jenkins/view/IbinF20x32/job/ros-indigo-cpp-common_binaryrpm_heisenbug_i386/10/console
[2] http://github.com/ros/roscpp_core/blob/indigo-devel/cpp_common/include/ros/header.h#L41
[3] http://github.com/smd-ros-rpm-release/roscpp_core-release/commit/e92922ec6b7c55aefa55e8f7c2c8a5cdae1535ca
[4] http://csc.mcs.sdsmt.edu/jenkins/view/IbinF20x32/job/ros-indigo-cpp-common_binaryrpm_heisenbug_i386/11/console

@cottsay

This comment has been minimized.

Copy link
Member Author

commented Jun 28, 2014

@dirk-thomas

This comment has been minimized.

Copy link
Member

commented Jun 28, 2014

Before the ROS package console_bridge was bringing in the boost dependency transitively. Since roscpp_core now uses the system package of console_bridge boost is not exposed as a transitive dependency anymore.

Anyway the packages in roscpp_core should state their direct dependencies explicitly anyway and not rely on transitive dependencies for this. Please see PR #25 for the proposed fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.