Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated logError macros. #69

Merged
merged 1 commit into from Oct 20, 2017

Conversation

Projects
None yet
2 participants
@dirk-thomas

This comment has been minimized.

Copy link
Member

commented Oct 20, 2017

Thanks.

@dirk-thomas dirk-thomas merged commit 01332ef into ros:kinetic-devel Oct 20, 2017

2 checks passed

Kpr__roscpp_core__ubuntu_xenial_amd64 Build finished.
Details
Lpr__roscpp_core__ubuntu_xenial_amd64 Build finished.
Details
@dirk-thomas

This comment has been minimized.

Copy link
Member

commented Nov 3, 2017

@mikepurvis This fails to build on Debian Jessie: http://build.ros.org/job/Kbin_dj_dJ64__cpp_common__debian_jessie_amd64__binary/7/

Can you please create a pull request which conditionally defines those macros if they don't exist. I will have to make another release into Kinetic then. Thank you.

@mikepurvis

This comment has been minimized.

Copy link
Member Author

commented Nov 3, 2017

Oh, I didn't realise Jessie was a supported platform for Kinetic. Will fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.