Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define macro with API call rather than relying on short macro being d… #71

Merged

Conversation

Projects
None yet
3 participants
@mikaelarguedas
Copy link
Contributor

commented Nov 18, 2017

…efined

Similar to ros/ros_comm#1235 and ros/class_loader#66

@dirk-thomas

This comment has been minimized.

Copy link
Member

commented Dec 19, 2017

Thanks for the patch.

@dirk-thomas dirk-thomas merged commit 64da30f into ros:kinetic-devel Dec 19, 2017

2 checks passed

Kpr__roscpp_core__ubuntu_xenial_amd64 Build finished.
Details
Lpr__roscpp_core__ubuntu_xenial_amd64 Build finished.
Details

@mikaelarguedas mikaelarguedas deleted the mikaelarguedas:console_bridge_0.2.x_compat branch Dec 19, 2017

@orhirshfeld

This comment has been minimized.

Copy link

commented on 33d68d0 Jul 11, 2018

I'm having some issue with this change
when i try to compile from source it return the following error:
‘CONSOLE_BRIDGE_LOG_ERROR’ is not a member of ‘console_bridge’

full log:
==> Processing catkin package: 'cpp_common'
==> Building with env: '/home/deltatau/ros_catkin_ws/install_isolated/env.sh'
Makefile exists, skipping explicit cmake invocation...
==> make cmake_check_build_system in '/home/deltatau/ros_catkin_ws/build_isolated/cpp_common'
==> make -j1 -l1 in '/home/deltatau/ros_catkin_ws/build_isolated/cpp_common'
[ 50%] Building CXX object CMakeFiles/cpp_common.dir/src/header.cpp.o
/home/deltatau/ros_catkin_ws/src/roscpp_core/cpp_common/src/header.cpp: In member function ‘bool ros::Header::parse(uint8_t*, uint32_t, std::string&)’:
/home/deltatau/ros_catkin_ws/src/roscpp_core/cpp_common/src/header.cpp:88: error: ‘CONSOLE_BRIDGE_LOG_ERROR’ is not a member of ‘console_bridge’
/home/deltatau/ros_catkin_ws/src/roscpp_core/cpp_common/src/header.cpp:102: error: ‘CONSOLE_BRIDGE_LOG_ERROR’ is not a member of ‘console_bridge’
make[2]: *** [CMakeFiles/cpp_common.dir/src/header.cpp.o] Error 1
make[1]: *** [CMakeFiles/cpp_common.dir/all] Error 2
make: *** [all] Error 2
<== Failed to process package 'cpp_common':
Command '['/home/deltatau/ros_catkin_ws/install_isolated/env.sh', 'make', '-j1', '-l1']' returned non-zero exit status 2

Reproduce this error by running:
==> cd /home/deltatau/ros_catkin_ws/build_isolated/cpp_common && /home/deltatau/ros_catkin_ws/install_isolated/env.sh make -j1 -l1

This comment has been minimized.

Copy link
Contributor Author

replied Jul 11, 2018

Can you please open a new issue for this? I'm afraid commenting on a commit won't have much visibility.

Ideally your issue should state what operating system you are using, what version of ROS and the exact steps to reproduce the issue.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.