Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #88. #89

Merged
merged 1 commit into from Aug 3, 2018

Conversation

Projects
None yet
2 participants
@csukuangfj
Copy link
Contributor

commented Jun 21, 2018

fix #88 .

@dirk-thomas

This comment has been minimized.

Copy link
Member

commented Jun 21, 2018

The patch looks good.

Can you please still describe in which case you ran into the problem. So how to reproduce the problem.

@csukuangfj

This comment has been minimized.

Copy link
Contributor Author

commented Jun 21, 2018

@dirk-thomas

A minimum example is as follows:

cmake_minimum_required(VERSION 3.0)
project(test_issue_88)

include(CheckCXXSourceCompiles)
CHECK_CXX_SOURCE_COMPILES("#include<cxxabi.h>\nintmain(intargc,char**argv){}" HAVE_CXXABI_H)
CHECK_CXX_SOURCE_COMPILES("#include<cxxabi.h>\nint main(int argc,char**argv){}" HAVE_CXXABI_H2)

message(STATUS "${HAVE_CXXABI_H}")
message(STATUS "${HAVE_CXXABI_H2}")

Output log

-- The C compiler identification is GNU 5.4.0
-- The CXX compiler identification is GNU 5.4.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Performing Test HAVE_CXXABI_H
-- Performing Test HAVE_CXXABI_H - Failed
-- Performing Test HAVE_CXXABI_H2
-- Performing Test HAVE_CXXABI_H2 - Success
-- 
-- 1
-- Configuring done
-- Generating done
@dirk-thomas

This comment has been minimized.

Copy link
Member

commented Jun 21, 2018

I was referring to how you triggered the problem with the current code of the package.

@csukuangfj

This comment has been minimized.

Copy link
Contributor Author

commented Jun 21, 2018

@dirk-thomas
I was reading the source code and found that it set HAVE_CXXABI_H incorrectly, so I proposed the pull request.

@dirk-thomas dirk-thomas merged commit 1110bb0 into ros:kinetic-devel Aug 3, 2018

3 checks passed

Kpr__roscpp_core__ubuntu_xenial_amd64 Build finished.
Details
Lpr__roscpp_core__ubuntu_xenial_amd64 Build finished.
Details
Mpr__roscpp_core__ubuntu_bionic_amd64 Build finished.
Details
@dirk-thomas

This comment has been minimized.

Copy link
Member

commented Aug 3, 2018

Thank you for the patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.