create_autonomy: 1.3.0-0 in 'indigo/distribution.yaml' [bloom]

[jacobperron]

Increasing version of package(s) in repository create_autonomy to 1.3.0-0:

• upstream repository: https://github.com/AutonomyLab/create_autonomy.git
• release repository: https://github.com/AutonomyLab/create_autonomy-release.git
• distro file: indigo/distribution.yaml
• bloom version: 0.6.4
• previous version for package: null

ca_description

* Migrate to package.xml format 2
  
  Minor linting to package files.
* Update install rules
* Refactor launch files and expose robot base and odometry frame IDs as parameters
* Refactor CMakeLists.txt and package.xml files and add missing install rules
* Contributors: Jacob Perron

ca_driver

* Add explicit dependency on catkin_EXPORTED_TARGETS
  
  This ensures ca_msgs is built before ca_driver.
* Migrate to package.xml format 2
  
  Minor linting to package files.
* Add roslint test and fix lint issues
* find_package libcreate instead of downloading as external project
* Add support for defining and playing songs
* Update install rules
* Refactor launch files and expose robot base and odometry frame IDs as parameters
* Refactor CMakeLists.txt and package.xml files and add missing install rules
* Contributors: Clyde McQueen, Jacob Perron

ca_msgs

* Migrate to package.xml format 2
  
  Minor linting to package files.
* Add support for defining and playing songs
* Refactor CMakeLists.txt and package.xml files and add missing install rules
* Contributors: Clyde McQueen, Jacob Perron

ca_tools

* Migrate to package.xml format 2
  
  Minor linting to package files.
* Update install rules
* Refactor launch files and expose robot base and odometry frame IDs as parameters
* Refactor CMakeLists.txt and package.xml files and add missing install rules
* Contributors: Jacob Perron

create_autonomy

* Migrate to package.xml format 2
  
  Minor linting to package files.
* Contributors: Jacob Perron

[mikaelarguedas]

While the repository name is explicit, the package names are not.
Please consider renaming them so that users can know what robot they apply to just by reading the package name.
More information can be found on the ROS Naming Conventions wiki page

[jacobperron]

@mikaelarguedas The current ca_ naming scheme arose because otherwise it might clash with the existing create_description and create_driver. I could rename ca_driver to create_base, but I'm not sure what to do with the description package.

Another possibility is to expand the prefix to create_autonomy_. ie:

• create_autonomy_description
• create_autonomy_driver
• create_autonomy_msgs
• create_autonomy_tools

Originally, I thought that this may be too verbose. Thoughts?

[tfoote]

It does feel long to type out, but I'd rather error on the side of being more verbose than less. Most of the time you won't type the whole thing out anyway, with tab completion, code auto complete, or using namespaces. I'd suggest going ahead with those names.

For some of them the name clash begs the question. Can they be merged/collapsed? For example could your create_autonomy_description be merged into the current create_description and not need the semi-duplicated package.

Also note that the _tools repo seems to be launch files so it would more classically be called _bringup following REP 144

[jacobperron]

@tfoote Thanks for the feedback.

It seems like a good idea to merge the description packages. It would involve adding URDF/mesh files for Create 2.

But the existing create_driver package is a Python module (used by turtlebot_node in the package create_node) whereas the create_autonomy driver is a ROS node for Create/Roomba platforms (no turtlebot specifics). Seems like the create_node package would be more aptly named turtlebot_node.

Perhaps more trouble than it's worth, but I would refactor the turtlebot packages to make use of either the create_autonomy driver or its underlying libcreate...

For now, I'll proceed with merging the description packages and renaming create_autonomy's packages.

[tfoote]

@jacobperron thanks for being willing to do the renaming. adding the new descriptions will definitely be a good thing.

The create_node was designed to be used in the TurtleBot but it's specifically implemented to be reusable outside the context of the TurtleBot.

It would be great to update the TurtleBot support to be able to use either implementation if you have the time. Unfortunately I don't have the create hardware available for testing.

[tfoote]

@jacobperron I'm going to close this and the other PRs for lunar and kinetic for now pending the rename. Once the packages are renamed, bloom can open new prs automatically.