Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rule for python3-lxml for mac os #20560

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@mikaelarguedas
Copy link
Contributor

mikaelarguedas commented Mar 13, 2019

@mjcarroll based on ros2/ros2#656 (comment) it looks like this definition will be needed for users using rosdep on MacOS. Is that right ?

With macOS: The dependency should be resolved either with rosdep [...]

add rule for python3-lxml for mac os
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>

@mikaelarguedas mikaelarguedas requested a review from ros/rosdeputies as a code owner Mar 13, 2019

@tfoote
Copy link
Member

tfoote left a comment

lgtm, though will it be python3 by default?

@mikaelarguedas

This comment has been minimized.

Copy link
Contributor Author

mikaelarguedas commented Mar 13, 2019

lgtm, though will it be python3 by default?

Yeah I had the same concern but saw that matplotlib below had a pip entry so assumed it worked in some cases.
I don't have any macOS machine available to try it on.
Looking at the wheels available it looks like there are separate binaries for python2 and 3, so it will likely be python2 :/

@mikaelarguedas

This comment has been minimized.

Copy link
Contributor Author

mikaelarguedas commented Mar 13, 2019

I'll assume that this will actually be the Python 2 version and close this PR.

@mikaelarguedas mikaelarguedas referenced this pull request Mar 13, 2019

Closed

Crystal Patch Release 3 #656

10 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.